Giter Club home page Giter Club logo

Comments (6)

mboudreau avatar mboudreau commented on August 24, 2024 2

Alright, version 6.19.4 is going out now with the fix and accompanying tests to prevent regression :)

from pact-js-core.

mboudreau avatar mboudreau commented on August 24, 2024

ah yep, you're correct. I did some refactoring and it screwed up the order of things. Let me fix that.

from pact-js-core.

mboudreau avatar mboudreau commented on August 24, 2024

Alright, I've fixed it and figured out how to add tests around this to prevent regression. Version 6.19.3 should be going out shortly. Cheers.

from pact-js-core.

niuwanlu avatar niuwanlu commented on August 24, 2024

@mboudreau Thank you for your very quick response. I've tried it, really works! Amazing! 👍

Still have a question. pact_binary_location can ONLY be set as absolute path, is it? Tried to set it to a relative path, it did't work.

from pact-js-core.

mboudreau avatar mboudreau commented on August 24, 2024

hm, I didn't think of that. It's a good point. Originally, it was built for a URL type of approach and not directory, but it makes sense to be able to do relative path based on where the package.json with the config is located.

Let me rejig it a bit to fix that.

from pact-js-core.

niuwanlu avatar niuwanlu commented on August 24, 2024

Really appreciate! Looking forward to it ;)

from pact-js-core.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.