Allow relative paths in pact publish task about pact-js-core HOT 6 CLOSED

@mefellows I'm looking into this one and thinking of adding something in the pact-util file that checks for paths/urls and then normalizes/resolves them if they're valid.

Currently though, we're a bit "laissez-faire" with the path validation as we do some minute checks on it, but nothing too concrete. I do agree that we need to have the ability to check relative vs absolute paths, however, should we also accept path shortcuts like ~/?

Also, when it comes to URLs, should we accept any protocols, or is it locked down to http(s)?

Trying to figure out the best way to do this as to implement it properly.

from pact-js-core.

The paths need to be relative to the directory you run the executable from - that might have been the issue. So you need to invoke the verifier using the relative path from the project root if possible.

Btw, there's an issue to change the paths from options to space separated arguments, so we don't have to do the comma separating thing.

from pact-js-core.

I don't see why other protocols could not be supported in the long term, i'm not sure what is currently supported beyond file:// and http://.

However I think we don't allow unix/bash/whatever-specific shortcuts like ~. I can't think of a situation where it's going to be terrible, but I can see implementation complexity with little value.

WRT other protocols, all that we need is the URL to be resolvable from the local host, and the Pact verifier to support it.

cc: @bethesque who also has some good knowledge around the verifier and might be able to assist.

from pact-js-core.

Why not just pass the paths in? The verifier should show an appropriate message. If it doesn't, let's change it to do it. No point duplicating code. The verifier can handle relative paths too, what's the problem you've found?

from pact-js-core.

Yeah from memory that was the problem, but I'm sure we can find a way to resolve it.

from pact-js-core.

Fixed in 6.15.0.

from pact-js-core.