Comments (1)
Attempting to generalize Mesh
to accept arbitrary tuples instead of SVector
s (to assess all possibilities for completeness), I've encountered a plethora of places where the assumption that mesh vertices are vectors is deeply ingrained. This has convinced me to simply draw the line at the buildmesh
level. We can still call bloch(ph, (params..., ϕs...)
with non-numeric params
(the full tuple is not converted to an SVector
, only the ϕs
part). In fact, thinking about it a bit more, it turns out that our new lift
approach for bandstructure
provides a perfect way to combine non-scalar parameters with Mesh
es that have purely SVector{D,<:Number}
vertices: just write an appropriate lift
that converts the vertex to the non-scalar parameter.
The actionable part of this issue is then simple: constrain the eltype of Mesh
vertices to be Number
s, and perhaps throw an informative error in case one tries to define a MeshSpec
with non-scalar vertices.
from quantica.jl.
Related Issues (20)
- Taking blocks seriously HOT 5
- Multiorbital systems: replace `SMatrixView` with a `Union` over different `SMatrix` eltypes HOT 1
- Provide wrappers to matrices / vectors to indicate parent Hamiltonian an allow use of siteselector HOT 8
- Allow construction of Hamiltonian by providing Harmonics HOT 2
- Segfault (use-after-free?) due to interaction between FunctionWrappers and Julia 1.10 HOT 1
- GreenFunction of AbstractHamiltonian{Float32} fails
- Add support for (energy dependent) unbounded self-energies HOT 1
- Add support for `qplot(h::OpenHamiltonian)`
- Parametric models don't support parameters without default values HOT 1
- Schur leads with additional self-energies are broken
- Issue with boundary construction in `GS.Bands`
- `GS.Bands` and Divide by zero
- Taking Operators seriously HOT 2
- Make `inspector = true` the default
- Broken closure in GreenFunction HOT 1
- Subtle aliasing issue in Schur slicer
- Allow for combination of parametric hamiltonian HOT 1
- Add selector indexing of `AbstractHamiltonian`s
- Tooltips in `plotlattice` of heterogenous multiorbital systems should show non-square blocks
- Spectrum not working for OpenHamiltonian HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from quantica.jl.