Giter Club home page Giter Club logo

Comments (1)

pablosanjose avatar pablosanjose commented on June 14, 2024 1

Attempting to generalize Mesh to accept arbitrary tuples instead of SVectors (to assess all possibilities for completeness), I've encountered a plethora of places where the assumption that mesh vertices are vectors is deeply ingrained. This has convinced me to simply draw the line at the buildmesh level. We can still call bloch(ph, (params..., ϕs...) with non-numeric params (the full tuple is not converted to an SVector, only the ϕs part). In fact, thinking about it a bit more, it turns out that our new lift approach for bandstructure provides a perfect way to combine non-scalar parameters with Meshes that have purely SVector{D,<:Number} vertices: just write an appropriate lift that converts the vertex to the non-scalar parameter.

The actionable part of this issue is then simple: constrain the eltype of Mesh vertices to be Numbers, and perhaps throw an informative error in case one tries to define a MeshSpec with non-scalar vertices.

from quantica.jl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.