compiler bug? global action about p4c HOT 3 CLOSED

I have created a new test case for this example. The problem is not the global action, but the copy-in copy-out of the fat structure. It looks like we generate incorrect code for assignment between structures. Ideally the compiler should figure out that it does not need to do structure copying at all, but we have some work to do to achieve that. Here is the generated code:

control IngressI(inout H hdr, inout M meta, inout standard_metadata_t smeta) {
    standard_metadata_t smeta_0;
    action drop_0() {
        smeta_0.drop = 1w1;
        smeta = smeta_0;
    }
    ...
}

The bmv2 back-end is not very robust yet.

from p4c.

I have submitted a fix which makes this compile. I have not checked that it runs correctly. It's still inefficient.

from p4c.

I can confirm that this compiles now.

from p4c.