Comments (3)
Could you add a PR with this example program and predication enabled in P4Test? I believe the pass is not used in many back ends because of how bug prone it is. There at least 7-8 incorrect transformation bugs in it.
It might be difficult to fix.
from p4c.
@fruffy I have attempted to do so in this PR #4371. Let me know if you wanted a different form for such a PR.
Understood if this might be difficult to fix -- I was not expecting anyone to tackle it soon. I mainly wanted to be sure the test case was preserved for testing a possible future fix.
Is there already a label to mark p4c issues that are believed to be related to bugs in the predication pass? Do you think it would be useful to create one?
from p4c.
I created a new label "Predication pass" and added that label to this issue. Feel free to use it for any other issues that might be bugs in that pass.
from p4c.
Related Issues (20)
- Add merge queue support
- `test-p4c / test-ubuntu20 (Unity OFF)` is very slow
- Introduce modern CMake build style and Ninja to P4C
- Finding the block statement of apply section HOT 1
- Revisit Protobuf include directory policy
- Get rid of `dynamic_cast` in filtering enumerator HOT 10
- Query: How to get started with Contributions HOT 3
- Reduce proliferation of cstrings HOT 6
- Compiler Bug: duplicate primitive converter for modify_field at priority HOT 6
- "Could not infer a type for parameter..." error should be removed HOT 1
- Compiler Bug: Expression E write set already set HOT 4
- [Docs Improvement] Compiler source code organization
- Compiler Bug: Overwriting definitions at <MethodCallExpression>(22038)//<MethodCallExpression>(22017)//<BoolLiteral>(1718) HOT 5
- verifying the condition of if statement HOT 6
- Protobuf & Abseil compilation pollutes build with a lot of warnings HOT 1
- Use a preprocessor library instead of calling into cc. HOT 15
- It should be possible to run the formatters without needing to install all P4C dependencies HOT 5
- The back ends (uBPF, eBPF, DPDK) should not be compiled or run tests if they are missing their dependencies. HOT 5
- Each back end should list its dependencies separately. The top-level dependencies should only list the dependencies necessary for p4test. HOT 6
- The formatters P4C CI uses are out of sync with the descriptions in the README. HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from p4c.