Comments (5)
let me know if you are happy with this, and if so, feel free to close this issue
from potrans.
Thanks,
I've am made some changes and split code into classes. That case can be handled with custom Translator
<?php
namespace potrans\translator;
use Gettext\Translation;
class DeepLTranslator extends TranslatorAbstract {
private \DeepL\Translator $translator;
public function __construct(\DeepL\Translator $translator) {
$this->translator = $translator;
}
/**
* @throws \DeepL\DeepLException
*/
public function getTranslation(Translation $sentence): string {
$response = $this->translator->translateText(
preg_replace('/\$([^$]+)\$/i', '<keep>$1</keep>', $sentence->getOriginal()),
$this->from,
$this->to,
[
'tag_handling' => 'xml',
'ignore_tags' => 'keep',
]
);
return preg_replace('/<\/?keep>/i', '$', $response->text);
}
}
from potrans.
Thank you! Any chance this will be included as an optional argument in the official release? Otherwise, I'll go ahead and close this issue.
from potrans.
sure, after rewriting there can be optional parameter for customized translator
from potrans.
there is new version that allow customize translator behavior
https://github.com/OzzyCzech/potrans#custom-translator
and this specific example is now called DeepLTranslatorEscaped.php and is part of the code
from potrans.
Related Issues (13)
- Feature recommendations HOT 1
- Invalid path to autoload.php
- Known Fatal error with join() function
- Cache doesn't take into account changed language HOT 1
- read deepl apikey from file or env
- Argument #1 ($translation) must be of type string, null given HOT 2
- Allow using non-free DeepL api endpoint [bug] HOT 2
- Correct autoload? HOT 3
- Allowed memory size of 134217728 bytes exhausted (tried to allocate 72 bytes) in /Users/vendor/sepia/po-parser/src/Sepia/PoParser.php on line 115 HOT 2
- Error "Server Error #403: " HOT 4
- Error "Server Error #400: " HOT 1
- Error "Server Error #403: " HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from potrans.