Application upgradation about spring-boot-email-tools HOT 12 OPEN

watching

from spring-boot-email-tools.

I think it makes total sense to move the PersistenceService implementation (redis) to its own module.
If having that module is a pain to maintain then remove it, but it’s good thing to have a reference implementation.

Regarding the templates, I guess that having one reference implementation it’s enough, mostly because the integration is very similar among those engines.

It is nice to have those integrations done, but if having them means that you don't have time (or motivation) to maintain the core, in that case just get rid of them.

from spring-boot-email-tools.

@cooligc not so soon I guess. I'm in rush with other projects, I don't have time to dedicate to the upgrade.

Indeed, this is an open source project. I'll accept contributions.

from spring-boot-email-tools.

I think that in the next days I may find the right mood for supporting Spring Boot 2.x in this project.

from spring-boot-email-tools.

I've started the upgrade. First thing I'm trying to accomplish, is to move the default services for REDIS persistence in a separate module. Since email persistence is not mandatory, I think that putting the default service there was a very bad idea.
I'm not sure how much time it will take the migration. There are dozens of broken tests and changes in SpringBoot2 that must be taken into account.

from spring-boot-email-tools.

Just was wondering if there was any progress on this? Thanks.

from spring-boot-email-tools.

@limpep I have a lot of issues, and every time I find a new one I lose interest. But I'm working on it. Unfortunately, I don't have a release date at the moment.

Wanna help?

from spring-boot-email-tools.

@robertotru I would love to help but I don't know where to begin plus I think I'll probably mess it up more than actually helping 😂

from spring-boot-email-tools.

I'm thinking about getting rid of the REDIS support (if one wants to have email persistence, can implement the service he prefers and also all the template engine but not Mustache.

This may speedup the upgrade.

Opinions?

from spring-boot-email-tools.

Branch is https://github.com/ozimov/spring-boot-email-tools/tree/feature/move-to-spring-boot-2.0.x

from spring-boot-email-tools.

Please indicate the compatible Spring boot version in the home page of the repository. It can save time from other developers who want to integrate this library into Spring boot 2 projects. I didn't see anything about this issue and started to integrate this library into my project and while running I got the error and after searching for the reason I have found this open issue.

from spring-boot-email-tools.

@rezaep it is on the top banner, but maybe it should be also in the readme. We also do accept PRs :)

from spring-boot-email-tools.