Giter Club home page Giter Club logo

Comments (8)

majestrate avatar majestrate commented on July 17, 2024

ideally we need to implement seek/discard of entities instead of just hard failing if they are not the expected format.

from lokinet.

majestrate avatar majestrate commented on July 17, 2024

idea, have llarp::IBEncodeMessage have a member for unrecondised values

from lokinet.

majestrate avatar majestrate commented on July 17, 2024

specifically a std::unordered_map<std::string, llarp_buffer_t> where key is the key name and value is a buffer containing its value.

from lokinet.

majestrate avatar majestrate commented on July 17, 2024

or.... potentially pass into llarp::IBEncodeMessage::BDecode a std::unordered_map<std::string, llarp_buffer_t> & to place in unknown fields.

from lokinet.

neuroscr avatar neuroscr commented on July 17, 2024

why would we need to store fields we don't know or can't do anything with in memory? Seems just like a waste of memory.

from lokinet.

majestrate avatar majestrate commented on July 17, 2024

it's not, it's a llarp_buffer_t which is a pointer to a region of memory, it doesn't copy it.

from lokinet.

majestrate avatar majestrate commented on July 17, 2024

oh, right, it's for older version to not die when parsing newer messages

from lokinet.

neuroscr avatar neuroscr commented on July 17, 2024

closing because no one cares any more

from lokinet.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.