Configuration is poorly typed and not explicitly defined about lokinet HOT 11 CLOSED

I think it's important to clarify, my commentary was actually on the representation of the configuration in code, not in the configuration files.

@neuroscr

from lokinet.

INI was chosen for UX. If other projects can use INI, it's probably possible somehow to make it work.

I'm against using YAML

appropriateness of using a library over custom, internally maintained, code

This is not a value we hold. More dependencies isn't always a good thing.

Compile-time safety is your strongest point here.

from lokinet.

liilac: if you want, we could go full TOML (ew) to gain access to more descriptive types 🤔

• wouldn't break existing configs

ye I also agree with ryan's position on external code

• code should be auditable
• simplifies packaging (at this time, it is possible to ship a fully linked binary with no external requirements other than [libc|msvcrt] and lib[std]c++)
• simplifies user experience for installation from source (rapidjson is header-only)

from lokinet.

At least TOML is like INI, it maybe a good compromise, if we need one
https://github.com/toml-lang/toml

from lokinet.

What was the reason for closing this? Would it be possible to get a summary of the thoughts and reasoning behind a deliberate choice to not (at some point) have a well-typed representation of the configuration in code? @majestrate

from lokinet.

from lokinet.

@majestrate I think you're misunderstanding the proposal here.

It's nothing to do with the configuration file format; comments on changes to that were tangential.

The proposal and discussion here (on my part), was about having a well-typed representation of the configuration in code; i.e. with structs and such.

Simplistic example in plain C:

typedef struct
{
    int listenPort;
    const char* nickname;
    // ...
} config;

from lokinet.

ah i see, that would make more sense.

from lokinet.

Might be helpful to link an exhaustive sample config here

from lokinet.

the sample config is generated by lokinet using the -g flag

from lokinet.

we have refactored the config layer to make things more strongly typed.

from lokinet.