[TinyYolo v2] Bug in maxpool? about onnx-go HOT 9 CLOSED

Maybe related: PR 274 from Gorgonia (from @lynic)

from onnx-go.

Does yolo use overlapping pooling? i.e. maxpool with a stride of other than size

from onnx-go.

@chewxy the stride of the operator is [1 1] (the third column)

from onnx-go.

I think I got it; the ONNX spec specifies that a ceil_mode attribute can change the behavior of the shape calculus:

ceil_mode : int (default is 0)
Whether to use ceil or floor (default) to compute the output shape.

The calcShape method in Gorgonia does not take this into account; the shape calculation is probably different than what onnx expects.

I will do different tests, but If this is the case, I will have to find a smart solution to implement this without breaking Gorgonia's API 🧐

from onnx-go.

I did not notice that the implementation of the SAME_UPPER was breaking the unit tests of gorgonnx:

--- FAIL: TestONNX (0.04s)
    --- FAIL: TestONNX/TestMaxpool2dSameUpper (0.00s)
        test_structure.go:78:
                Error Trace:    test_structure.go:135
                Error:          Max difference between 1.7640524 and 0.978738 allowed is 1e-06, but difference was 0.7853143811225891
                Messages:       the two tensors should be equal.
    --- FAIL: TestONNX/TestMaxpool2dPrecomputedSameUpper (0.00s)
        test_structure.go:78:
                Error Trace:    test_structure.go:135
                Error:          Max difference between 1 and 7 allowed is 1e-06, but difference was -6
                Messages:       the two tensors should be equal.
FAIL

Let's fix this before going further.

from onnx-go.

Probably related to ONNX issue #1113

from onnx-go.

The problem linked to #74 and because the padding is asymmetric;
this is not implemented in Gorgonia.

from onnx-go.

Should be fixed with PR #80 and PR #295 from Gorgonia

from onnx-go.

Tiny yolo v2 is working, let's make it fast now!

from onnx-go.