[tests] replace testify.Assert by assert.Assert about onnx-go HOT 4 CLOSED

Hi,
you are using assert.InDeltaSlice which is testify specific. Do you want to move and reimplement this with the test tools?

from onnx-go.

Good point!

I realize that most values are interfaces{}, and that would impose a signature:

func inDeltaSlice(a, b interface{}, precision float32) bool {}

and then playing with reflection... Do we really want to do that? I don't think so.

Or maybe, as most tests are using known values, we could use something like:

func inDeltaSliceF32(a, b []float32, precision float32) bool {}
func inDeltaSliceF64(a, b []float32, precision float32) bool {}

and to use it with

assert(t,inDeltaSliceF32(a.([]float32), b.([]float32), 1e-6),true)

Or we simply drop this issue and keep on using testify.

WDYT?

from onnx-go.

In the light that the saved dependencies only affect testing and do not compile into production I wouldn't mind having a bit more comfort. While the other framework is showing good potential.

from onnx-go.

Agreed. I am closing this issue.
Thanks @enc for your time.

from onnx-go.