All E2E nightly tests for `app-provider` are failing about web HOT 11 CLOSED

I see this error in the browser log:

maybe this is for app query param: ?app=Collabora. just a guess because url with ?app=Collabora works but others don't

I'll fix this! Was able to reproduce it locally.

from web.

#11103 was merged without [full-ci] tag in the PR title so we we missed this regression

from web.

@saw-jan I fixed the bug in the web ui, but the tests still need to be adjusted afaict. Could you take over?

from web.

@saw-jan I fixed the bug in the web ui, but the tests still need to be adjusted afaict. Could you take over?

Okey, will push a PR with adjustments

from web.

Thank you @saw-jan ❤️

from web.

Hmm, the change was made in PR #11103.
now we have /external-onlyoffice/ and /external-collabora/ url paths instead of /external/. this breaks the tests.
This can be fixed in the test.

But we have test scenario for url navigation which navigates to:
/external/open-with-web/?appName=${editorName}&fileId=${fileId}
from desktop client: /external?contextRouteName=files-spaces-personal&fileId=${fileId}
web cannot load this url:

/external/open-with-web/?appName=${editorName}&fileId=${fileId}
/external?contextRouteName=files-spaces-personal&fileId=${fileId}

should this url work?

CC @ScharfViktor @kulmann

from web.

These urls doesn't work: ❌

• desktop-client: /external?contextRouteName=files-spaces-personal&fileId=${fileId}
• /external/open-with-web/?appName=${editorName}&fileId=${fileId}

but this does: ✔️

• /external?app=${editorName}&contextRouteName=files-spaces-personal&fileId=${fileId}

from web.

Ah dang, everything correct here, I forgot [full-ci] on #11103 - sorry for the trouble.

#11103 brought new URLs for the specific app provider apps (e.g. /external-collabora/ instead of /external/...?app=Collabora for Collabora). However, I built a redirect page so that the old URLs with only /external/ in the path continue to work and do a redirect to the new URLs. That also includes the URLs that the backend generates on the endpoint /external/open-with-web.

My assumption is that the e2e tests need to learn to wait until after the redirect has happened. During the redirect the page with One moment please... is visible.

Should I take care of this myself? If yes, please assign me to this issue.

from web.

During the redirect the page with One moment please... is visible.

how long does the redirect takes? because I couldn't see the online office even waiting for some time. so I was wondering if redirect was working

from web.

Should I take care of this myself? If yes, please assign me to this issue.

I will take care of it if it's only the test code adjustments

from web.

I see this error in the browser log:

maybe this is for app query param: ?app=Collabora. just a guess because url with ?app=Collabora works but others don't

from web.