Comments (11)
I see this error in the browser log:
maybe this is for
app
query param:?app=Collabora
. just a guess because url with?app=Collabora
works but others don't
I'll fix this! Was able to reproduce it locally.
from web.
#11103 was merged without [full-ci] tag in the PR title so we we missed this regression
from web.
@saw-jan I fixed the bug in the web ui, but the tests still need to be adjusted afaict. Could you take over?
from web.
@saw-jan I fixed the bug in the web ui, but the tests still need to be adjusted afaict. Could you take over?
Okey, will push a PR with adjustments
from web.
Thank you @saw-jan ❤️
from web.
Hmm, the change was made in PR #11103.
now we have /external-onlyoffice/
and /external-collabora/
url paths instead of /external/
. this breaks the tests.
This can be fixed in the test.
But we have test scenario for url navigation which navigates to:
/external/open-with-web/?appName=${editorName}&fileId=${fileId}
from desktop client: /external?contextRouteName=files-spaces-personal&fileId=${fileId}
web cannot load this url:
/external/open-with-web/?appName=${editorName}&fileId=${fileId}
/external?contextRouteName=files-spaces-personal&fileId=${fileId}
should this url work?
from web.
These urls doesn't work: ❌
- desktop-client:
/external?contextRouteName=files-spaces-personal&fileId=${fileId}
/external/open-with-web/?appName=${editorName}&fileId=${fileId}
but this does: ✔️
/external?app=${editorName}&contextRouteName=files-spaces-personal&fileId=${fileId}
from web.
Ah dang, everything correct here, I forgot [full-ci]
on #11103 - sorry for the trouble.
#11103 brought new URLs for the specific app provider apps (e.g. /external-collabora/
instead of /external/...?app=Collabora
for Collabora). However, I built a redirect page so that the old URLs with only /external/
in the path continue to work and do a redirect to the new URLs. That also includes the URLs that the backend generates on the endpoint /external/open-with-web
.
My assumption is that the e2e tests need to learn to wait until after the redirect has happened. During the redirect the page with One moment please...
is visible.
Should I take care of this myself? If yes, please assign me to this issue.
from web.
During the redirect the page with One moment please... is visible.
how long does the redirect takes? because I couldn't see the online office even waiting for some time. so I was wondering if redirect was working
from web.
Should I take care of this myself? If yes, please assign me to this issue.
I will take care of it if it's only the test code adjustments
from web.
I see this error in the browser log:
maybe this is for app
query param: ?app=Collabora
. just a guess because url with ?app=Collabora
works but others don't
from web.
Related Issues (20)
- OCM. Identify federated users on a web page HOT 1
- numerical tags causes serious problem! HOT 9
- Add e2e test for adding numerical tags on a resource HOT 2
- Resource table doesn't show Tag column. is there any setting or configuration to show the Tag column? HOT 12
- Simplify Link sharing dialog HOT 1
- Space context menu is cropped with limited vertical screen space
- Setting a readme space description is not reactive
- Thumbnails are displayed in some places and in some places not HOT 5
- Shared file details contains not clear Shared via path HOT 1
- Remove unused config var options.sharingRecipientsPerPage
- Get rid of the options.sidebar.shares.showAllOnLoad config option
- Get rid of the `options.sidebar.exif.showLocation` config option
- Get rid of the `options.hoverableQuickActions` config option
- Check if config options `topCenterNotifications` and `displayResourcesLazy` can be dropped
- Remove config option `option.routing`
- Remove config option `options.upload.xhr.timeout`
- Remove config option `options.openLinksWithDefaultApp `
- Remove config option `options.ocm.openRemotely` HOT 1
- Make open file or folder in new tab a user choice HOT 8
- SSE adapter is throwing errors on reload HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from web.