Giter Club home page Giter Club logo

Comments (2)

skshetry avatar skshetry commented on August 20, 2024

@phil-davis, currently, if the federation app cannot be started, there are no imported modules that we can use in the testing app. This would have been fine if the Http response to the APIs in the testing app would throw some 4XX/5XX status code (better response is always better, though).

Sadly, the response is 200 OK and empty body content, which will pass most of our assertions (where we check that status code is 200) and gives very ambiguous parsing errors (eg. where we do res.json()).

When the testing app fails, it should give 5XX errors, not 200. We should prioritize this at least in this sprint or the very next.

cc @HariBhandari07

Try yourself:

  1. Disable federation
  2. curl http://admin:admin@localhost/core/ocs/v1.php/apps/testing/api/v1/file --verbose

from testing.

phil-davis avatar phil-davis commented on August 20, 2024

This was noticed when trying to run a selection of acceptance tests against a system that had federation disabled. In that situation we should still be able to run "ordinary" acceptance test scenarios that do not need or test the federation features.

I added this to "Backlog for planning" so that it gets noticed, and someone can at least have a short look and report what might be possible to do.

from testing.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.