oc-file-actions: missing props ... about owncloud-design-system HOT 3 CLOSED

1. https://github.com/owncloud/owncloud-design-system/blob/master/src/templates/Files.vue#L258-L261

I was missing this part ... let me retry this .... still not convinced in my vue comfort zone ;-)

from owncloud-design-system.

1. actions for the file are passed in the event like in https://github.com/owncloud/owncloud-design-system/blob/master/src/patterns/OcFileActions.vue#L173 and in https://github.com/owncloud/owncloud-design-system/blob/master/src/templates/Files.vue#L258-L261
   While that works as designed the parameter payload should probably not be called file. Maybe stich with payload, as it contains a fileobject and anactions` array.

2. toggling via a bound variable creates a coupling between the file actions and the template it is being used on. using events is less coupled, IMO. If we want the file actions to be triggered from anywhere in the UI doing that via a shared state requires more work than by using the global event system.

3. file name is passed in via the event as well.

it might make sense to pull all this from the store. @felixheidecke mentioned something like that ... but it was a little outside my vue comfort zone.

from owncloud-design-system.

works - no need to change anything -> closing

from owncloud-design-system.