Giter Club home page Giter Club logo

Comments (8)

nickvergessen avatar nickvergessen commented on July 20, 2024

Well in 8.2 it was not an official app, but it is in 9.0 so from that on it should not get disabled anymore.

from announcementcenter.

MorrisJobke avatar MorrisJobke commented on July 20, 2024

This was an upgrade from 9.0.0 master yesterday to master today (test of the tag column switch from int to string)

from announcementcenter.

nickvergessen avatar nickvergessen commented on July 20, 2024

Okay right, the appstore says the app is official, but it's not in shipped.json which is checked on update.

The problem is, if we add it there, community people (where the app is not shipped) will have a problem, because for them the app needs to be disabled on update and then grab the new version from the appstore.

from announcementcenter.

MorrisJobke avatar MorrisJobke commented on July 20, 2024

The problem is, if we add it there, community people (where the app is not shipped)

Why is it not shipped in the community version? 😕 - @karlitschek

from announcementcenter.

nickvergessen avatar nickvergessen commented on July 20, 2024

Because we don't want to ship everything?
It's in the app store, the only reason why it is shipped in EE is because we don't support the appstore there yet. See owncloud/core#19152 (comment) and following

from announcementcenter.

MorrisJobke avatar MorrisJobke commented on July 20, 2024

Because we don't want to ship everything?

Then we need to check our core logic - announcing an official app as 3rdparty during update and then disable it sounds totally weird.

from announcementcenter.

karlitschek avatar karlitschek commented on July 20, 2024

in the future we have to avoid the situation that an app is in the tar in EE and in the app store in CE. this is weird. too late to change the logic now before 9.0 so we have lot keep it for now. in the future we only should have one way to distribute one app.

from announcementcenter.

nickvergessen avatar nickvergessen commented on July 20, 2024

So closing, as

is this correct?

Is indeed correct.

from announcementcenter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.