Comments (8)
Well in 8.2 it was not an official app, but it is in 9.0 so from that on it should not get disabled anymore.
from announcementcenter.
This was an upgrade from 9.0.0 master yesterday to master today (test of the tag column switch from int to string)
from announcementcenter.
Okay right, the appstore says the app is official, but it's not in shipped.json which is checked on update.
The problem is, if we add it there, community people (where the app is not shipped) will have a problem, because for them the app needs to be disabled on update and then grab the new version from the appstore.
from announcementcenter.
The problem is, if we add it there, community people (where the app is not shipped)
Why is it not shipped in the community version?
from announcementcenter.
Because we don't want to ship everything?
It's in the app store, the only reason why it is shipped in EE is because we don't support the appstore there yet. See owncloud/core#19152 (comment) and following
from announcementcenter.
Because we don't want to ship everything?
Then we need to check our core logic - announcing an official app as 3rdparty during update and then disable it sounds totally weird.
from announcementcenter.
in the future we have to avoid the situation that an app is in the tar in EE and in the app store in CE. this is weird. too late to change the logic now before 9.0 so we have lot keep it for now. in the future we only should have one way to distribute one app.
from announcementcenter.
So closing, as
is this correct?
Is indeed correct.
from announcementcenter.
Related Issues (20)
- Drone setup HOT 1
- [For Semver] Announcement Center 1.2.1 HOT 2
- Add owncloud coding standard test in drone
- jQuery 3 Upgrade
- Remove travis
- Standardize CI HOT 1
- Investigate phan error report HOT 1
- Fix unit test function name so that test runs (and fails) HOT 3
- Anouncement notification-link URI invalid
- [strictly 10.8.0] Announcementcenter 1.2.2 HOT 1
- Use new doctrine/dbal methods
- Announcement noticication is not rendered when message is not supplied
- announcement center HOT 3
- Error clicking link on announcement bluebell HOT 2
- Label doesn't shown up on new announcements!!! HOT 2
- Pop-up window for new announcement
- php-cs-fixer HOT 3
- Announcement Center Icon is not shown using Mozilla Firefox as browser HOT 3
- jQuery 2 Migration HOT 1
- announcementcenter not working with notification dependency in OC 10.0.9
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from announcementcenter.