Giter Club home page Giter Club logo

Comments (8)

jancborchardt avatar jancborchardt commented on August 28, 2024

@eMerzh can you also implement it as described: Ā»Have a bar on the bottom of the leftcontent and a settings cog on the right of that. Clicking the cog should move up that bar and reveal the settings (working as a toggle to close them again also).Ā«

This is not in the News app yet, but we work on phasing out the settings Ā»speech bubbleĀ« as it just looks out of place. Sorry for the hassle. :)

from apps.

eMerzh avatar eMerzh commented on August 28, 2024

@jancborchardt Oups sorry i haven't read that part :)

To be sure to understand, you want the setting to totally cover the left bar ?
i'll look at appsetting to see how i can do that ;)

from apps.

jancborchardt avatar jancborchardt commented on August 28, 2024

@eMerzh the settings shouldnā€™t fully cover the left sidebar. The bottom bar should slide up, revealing the settings (they donā€™t need much space ā€“ and if they do they need to be simplified ;). It should work similar to how the settings in the app navigation slide up now (that will be removed in the redesign, so we can use it for in-app settings).

from apps.

eMerzh avatar eMerzh commented on August 28, 2024

@jancborchardt i've tried to fit everything in the dialog and to implement what you suggested ...
could you please review that it fit your vision , and if it its the case, closing the ticket?

Thanks

from apps.

jancborchardt avatar jancborchardt commented on August 28, 2024

@eMerzh nice, thatā€™s already pretty much it! Just 3 things: it should slide up instead of just appearing, use jQuery.slideUp(). The background should be #eee instead of white. And when itā€™s opened, there is a big blank space to the bottom of the screen for some reason.

from apps.

jancborchardt avatar jancborchardt commented on August 28, 2024

@eMerzh 2 more, sorry :) 1) sliding works smoothly, except on the first time opening it, it just appears. 2) The settings should slide down again when you click anywhere outside of the settings element. (say on an element in the sidebar or a bookmark).

from apps.

jancborchardt avatar jancborchardt commented on August 28, 2024

YES! šŸš€

from apps.

cosenal avatar cosenal commented on August 28, 2024

Can you move the new settings slideup in the core, so that it can be used by other apps too? Thanks.

from apps.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    šŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. šŸ“ŠšŸ“ˆšŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ā¤ļø Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.