Giter Club home page Giter Club logo

Comments (2)

bamarch avatar bamarch commented on July 19, 2024

If we looked at doing this, and did not implement "lock_timeout" as an explicit parameter, think of the following problem:

The user specifies say lock-timeout=30s for plan and apply, passed in as a arbitrary argument to each.

How would the orb know to use this parameter for init (called implicitly) as well?

The commands all have a different set of supported parameters (init/plan/apply etc...) so the arbitrary args couldn't be applied everywhere TF is called by the orb.

#113 looks good to me - I think the parameters should be evaluated and added as the need arises - the arbitrary way makes something complex appear simple and might lead to issues imo

from circleci-orbs.

steinybot avatar steinybot commented on July 19, 2024

That is a good point. I'm not too bothered by not having this if the forwards compatibility isn't worth the hassle.

One way that I can think to workaround the problem would be to have separate parameters for each command such as init_parameters and plan_parameters.

from circleci-orbs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.