Giter Club home page Giter Club logo

Comments (5)

lloydbenson avatar lloydbenson commented on August 19, 2024

I am not sure what you have in mind here. Rejoice is simply a CLI utility that uses the glue manifest to start up. Do you have a PR in mind?

from rejoice.

asaf avatar asaf commented on August 19, 2024

@lloydbenson Plugins may require more than just JSON to be configured,
example can be https://github.com/iceddev/hapi-strategy plugin that adds a strategies (it requires the validation function to be passed as apart of the strategy options)

There must be a way to add extra plugins written in code and combine them to the overall plugin list passed to glue, otherwise any plugin that consumes functions to be configured cannot be used with rejoice, Unless i'm missing something, I think it's a hard limitation.

from rejoice.

lloydbenson avatar lloydbenson commented on August 19, 2024

The point of rejoice is to use just a simple json structure and having the cli use that. You don't obviously have to use rejoice, you can use glue directly and many people prefer that if they like to express it via code vs configuration. I think what you are saying here is that you want the glue manifest to be more expressive. Wouldn't that be a glue issue you'd want to address? Or am I still missing the point?

from rejoice.

asaf avatar asaf commented on August 19, 2024

Glue has some hooks (such prePlugins), rejoice hides them,
I'm also unable to register plugin programmatically (via my plugin defined in the manifest) because Hapi fails when registering a plugin via a plugin.

To summarize: there is no way to hook plugins that requires function references when using rejoice.

Feel free to close the issue if you guys never hit such a requirement ;)

from rejoice.

lloydbenson avatar lloydbenson commented on August 19, 2024

I think you can use glue if you want to do programmatic registering rather than rejoice. If we wanted to do something in rejoice, I'd like it to be represented as a JSON object as that is the major goal of this repo. I will close this up but if you have other thoughts on the subject let me know.

from rejoice.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.