Describing a url that has a faulty og:url value fails about metaphor HOT 6 CLOSED

At the same time, you should really consider changing the api so that it follows the standard way of asynchronous calls in javascript.

The normal way of a module like metaphor would be:

var metaphor = require('metaphor')
var engine = new metaphor.Engine()

engine.describe(myUrl, function (err, res) {
  if (err) ...handle the error somehow
  console.log(res)
})

from metaphor.

@freeall nope. It doesn't return an error. If it fails to get a description you just get an empty one. I don't care about errors and I don't want to handle them (or explicitly ignore them).

from metaphor.

@hueniverse but the problem is then that my application will then crash. Instead you should send errors to a callback.

The normal way would be something similar to:

module.exports = function (url, options, callback) {
  // when errors happen do callback(err)
  // when no errors happen do callback(null, someObject)
})

from metaphor.

@freeall No need to explain to me what the callback usually looks like. I've been writing node modules for a while now. You are missing the point. You application will never crash because all errors are already handled internally. This was a bug, not an incorrect API format.

from metaphor.

@hueniverse ok :) But errors from request will make the program crash. And it did. We ended up forking your module (which is super useful, by the way) just so we could handle errors.

from metaphor.

If you are getting errors, those are bugs and you should open issues. Can you provide examples for requests that caused it to crash?

from metaphor.