Comments (8)
Nice. Looks like you even fixed a bug that would let the environment variable
for MISC_MODULES override the command line. Thanks!
I'll apply this soon, but likely as two separate patches (one to fix the
PDSH_MISC_MODULES handling, and one for PDSH_REMOTE_PDCP_PATH)
Original comment by [email protected]
on 27 Jan 2011 at 11:36
- Changed state: Accepted
from pdsh.
Hm, actually I confused myself, opt_env() was always called before opt_args and
opt_args early. Was there a reason you moved opt_env() after mod_init() and
created
an opt_env_early()? I'm sure there is, and I don't have any problem with it, but
I can't quite see why it is necessary (here at the end of the day)
Thanks!
Original comment by [email protected]
on 28 Jan 2011 at 12:05
from pdsh.
Only the new bit concerning PDSH_REMOTE_PDCP_PATH has to run after mod_init().
Otherwise, _mod_load_dynamic_modules() fails to locate the local binary. I
didn't have any particular reason to move the other options into the "late"
opt_env rather than leave them in opt_env_early - it was just the way I
happened to copy-paste the bits around.
Original comment by [email protected]
on 28 Jan 2011 at 12:13
from pdsh.
Yes, ok, that makes sense. Thanks, again!
Original comment by [email protected]
on 28 Jan 2011 at 12:15
from pdsh.
Since the use of opt->path_progname for both local and remote paths was
confusing
even to me, I separated them in the options structure. This simplified your
patch a
bit since we no longer need opt_env_early().
I'll commit the patch soon, at which point it would be great if you could
verify it
does what you need.
Thanks again,
mark
Original comment by [email protected]
on 12 Feb 2011 at 4:02
from pdsh.
This issue was closed by revision r1272.
Original comment by [email protected]
on 12 Feb 2011 at 4:44
- Changed state: Fixed
from pdsh.
Confirming this works in 2.25. Thanks!
Original comment by [email protected]
on 15 Mar 2011 at 8:28
from pdsh.
Great, thanks for verifying!
Original comment by [email protected]
on 16 Mar 2011 at 9:00
- Changed state: Verified
from pdsh.
Related Issues (10)
- genders module doesn't properly support query HOT 6
- dshbak: Support sending output to one file per host HOT 1
- Add torque module HOT 7
- Support forwarding stdin in pdsh HOT 2
- List conflicting modules in -V and -L output HOT 4
- "Artifial issue": pshbak -c collects hostnames wrong-ish for some cases HOT 7
- Execute different command per target host
- pdsh hangs on creating a daemon process HOT 3
- PDSH_SSH_ARGS_APPEND doesn't work HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pdsh.