Giter Club home page Giter Club logo

Comments (8)

shubhexists avatar shubhexists commented on July 20, 2024 3

Should I try adding Linux here

if platform.system() == "Windows":

and see what the result is ?
Edit - Because I dont think Key down is as common as windows key...

from self-operating-computer.

michaelhhogue avatar michaelhhogue commented on July 20, 2024 2

@shubhexists This is a known issue. For now, the search command is tailored for Mac OS. Restricting your prompt to reference UI elements which are already on-screen is a work-around. Having a set way to open a launcher/menu via key shortcuts is going to be more difficult in Linux as there isn't one set way to open the launcher/menu like in Mac OS.

One possible way to resolve this issue on GNU/Linux could be to simply prompt the user for their keyboard shortcut to open a launcher/menu/search.

from self-operating-computer.

shubhexists avatar shubhexists commented on July 20, 2024 1

Hi I solved it and now it is searching applications using the windows key...
If you agree, I can make a PR adding this to the main repository?
Edit - It seems brave has a diff position for search bar than chrome : ) That required manual intermission

Demo

Screencast.2023-12-01.20.58.07.mp4

from self-operating-computer.

stefangrotz avatar stefangrotz commented on July 20, 2024

Windows Key + type should work in most Linux distros (+ in Windows). I will test it later and maybe also create a PR with a fix for Ubuntu.

from self-operating-computer.

shubhexists avatar shubhexists commented on July 20, 2024

I guess I agree that windows key + type might be an option that may cover a much wider range of devices

from self-operating-computer.

michaelhhogue avatar michaelhhogue commented on July 20, 2024

@shubhexists Yeah this is a good default. It personally isn't the key I use to open the menu (I have a keyboard intended for Macs, so I have command/alt open the menu), so I'm probably biased against it. But you are right, this is certainly most common for Linux.

from self-operating-computer.

michaelhhogue avatar michaelhhogue commented on July 20, 2024

@shubhexists That looks great! This should be a good PR.

from self-operating-computer.

joshbickett avatar joshbickett commented on July 20, 2024

Merged the PR. Thanks for monitoring @michaelhhogue and adding the code @shubhexists

from self-operating-computer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.