Giter Club home page Giter Club logo

Comments (6)

OtherCrashOverride avatar OtherCrashOverride commented on July 22, 2024 1

The issue originates from this being an unusual bitstream. It is MPEG4 (like DivX) but has H264 start codes. However, since it is not AnnexB compliant, I added a code path to work around the issue.

In the branch "next", the following commit works around this issue:
ea965bd

[Edit]
Note that for the sample provided, there are audible gaps in the sound stream. These are also present on Kodi and VLC (x86) and do not indicate a problem with c2play.

[Edit2]
The hang happens as a result of bad data being sent to the codec kernel driver. Preventing the hang would require additional validation in the kernel driver by Amlogic.

from c2play.

OtherCrashOverride avatar OtherCrashOverride commented on July 22, 2024

I can reproduce this issue and am working on a fix.

from c2play.

bkrepo avatar bkrepo commented on July 22, 2024

This media file works on next branch. 👍
About haining in the kernel side, could you suggest simple sample code in order to reproduce the hang?
We will look into the problem after the codec driver hang issue is uploaded to the odroid forum or HK's linux repository.

from c2play.

OtherCrashOverride avatar OtherCrashOverride commented on July 22, 2024

could you suggest simple sample code in order to reproduce the hang?

My only suggestion would be to use the v1.0.0 version of c2play with the sample media you provided. The hang is likely dependent on codec firmware micro-code as well. The data to hang it will likely differ for MPEG4, H264, and HEVC.

For this particular issue, the data being sent to the codec was raw data contained in the video packet:
https://github.com/OtherCrashOverride/c2play/blob/master/src/Media/AmlVideoSink.cpp#L351

This difference now is that the "extra data" is parsed as H264 and sent before that same data that hung decoder is sent.

c2play/src/Media/AmlVideoSink.cpp

Lines 269 to 272 in ea965bd

SendCodecData(pts, &videoExtraData[0], videoExtraData.size());
}
SendCodecData(pts, pkt->data, pkt->size);

from c2play.

bkrepo avatar bkrepo commented on July 22, 2024

Okay, thank you @OtherCrashOverride.

from c2play.

OtherCrashOverride avatar OtherCrashOverride commented on July 22, 2024

This should now be fully resolved in the 'next' branch. Please feel to open another issue if you experience any further issues.

from c2play.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.