improve binary artifact and license tests to match other checks about scorecard HOT 4 CLOSED

I think maybe I can work on this one? I haven't used gomock before, but it looks like BinaryArtifacts uses a lot of the same functions as DangerousWorkflow so hopefully I can figure it out.

from scorecard.

DangerousWorkflow should be a good template, but happy to answer any questions as needed

from scorecard.

(@spencerschrock) - currently the ListLicenses function for the localDirRepo client throws an Unsupported Feature error, which is then handled by the raw license check. Options I see include

1. create a mock that just throws an UnsupportedFeature error, similar to the existing functionality (I already have a working version of this, I think)

2. create a mock that actually returns something from ListLicenses, however, that would replicate a lot of the existing functionality for handling these cases in the check itself

3. Testing both 1 and 2 using different test cases with different mocks (adding a couple test cases to do so), although it seems like the difference in functionality should be tested in the raw/checks/license_test rather than here, so this might involve some other test design decisions

My questions are along the lines of - Is the functionality in the license check that handles an unsupportedFeature for listLicenses intended to be permanent? Are any of the options above preferable given the test designs for the project?

I am probably over-thinking this. If so and if option 1 is fine, I can go ahead and submit a PR.

Thanks!

from scorecard.

Option (1) sounds reasonable and a more direct translation of the existing tests, and would be a good first PR.

Depending on how much you want to do, creating a separate test which uses ListLicenses (effectively option 3) also sounds good.

from scorecard.