Comments (2)
By default, GitLab GraphQL returns the most recent merges on a GitLab repo. But we don't guarantee the merge request that brought in a commit on a GitLab repo's main branch is captured by our check - we may undercount - or miss - merge requests in zip if GraphQL and the REST API don't line up. (We use 1 GraphQL query + 1 REST API call instead of 1 REST API call per commit to find the linked Merge Request, which wouldn't scale).
The purpose of using mergedBefore
in getMergeRequestDetail
is to improve this - "don't give me any merge requests newer than the newest commit I've listed". But, I think you're right that before := commitsRaw[0].CommittedDate
may not reflect the commit date of the newest commit (it might be much older, therefore leading to a lower score). We might fix this is to find a better bound commit date in commitsRaw
, or by making a single API query to ListMergeRequestsByCommit
to get the right date for before
.
from scorecard.
Bug affects scoring at the margins
from scorecard.
Related Issues (20)
- Feature: Document whether scorecard should be used as a requirement for organizations consuming OSS HOT 2
- BUG - Pinned-Dependencies has false positive on multi-stage Dockerfile HOT 1
- BUG Sonarcloud not detected consistently HOT 4
- Bug: tools/go.mod has invalid Go version 1.22 HOT 3
- restore ability to see individual PR results for SAST and Code-Review and document it
- Incorrectly formatted example link HOT 2
- BUG: .Net Pinned dependency check ignores using RestoreLockedMode
- BUG: .Net pinned dependency should support Central Package Management HOT 1
- Feature: Checks should support powershell scripts
- Request: make the internal/packageclient package not internal HOT 5
- BUG githubrepo.Client.GetOrgRepoClient() does not use parent Client transport HOT 3
- Feature: scorecard.Run() should accept an http.RoundTripper to be used for all outgoing http requests HOT 2
- Feature scorecard.Run() should take a leveled logging object/interface instead of or alternatively to log level. HOT 2
- Documentation: Document how to call Scorecard as a library. HOT 1
- Update Code Section Format in Readme
- Investigate GitHub commit status failures HOT 1
- BUG HOT 1
- Proposal: Align Scorecard checks with S2C2F Maturity Level 2 requirements
- document and implement changes to the BigQuery schema HOT 1
- Internal Go error when scanning a package internal to my own gitlab instance HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from scorecard.