PHP strict declarations warnings on ProductBundle about orocommerce HOT 9 CLOSED

@gplanchat Please show composer show --installed | grep oro output here

from orocommerce.

$ composer show --installed | grep oro
oro/calendar-bundle                        1.0.0-beta.5       Oro Calendar Bundle
oro/commerce                               1.0.0-beta.5       OroCommerce - an open-source Business to Business Commerce application. \nThis package contains bundles and needs to be added ...
oro/doctrine-extensions                    1.0.13             Doctrine Extensions for MySQL and PostgreSQL.
oro/platform                               1.10.10-beta.5     Business Application Platform (BAP)
synolia/oroneo                             0.2.1              OroCommerce Akeneo connector

from orocommerce.

To be mentioned, the warnings seems to be in the notifications panel and appearing on each page refresh now

Edit : probably linked to the fact I ran an attribute import with the Akeneo connector

from orocommerce.

It seems to be coming from the Akeneo-Oro connector's strategy object.

I'm still investigating

from orocommerce.

@gplanchat looks like you are trying to create already existing fields
https://github.com/synolia/oroneo/blob/9457f3748ac1d81d8cdff50d228d234dae65071a/Migrations/Data/ORM/SetDefaultMappings.php#L78-L79 based on this configuration in https://github.com/synolia/oroneo/blob/9457f3748ac1d81d8cdff50d228d234dae65071a/ImportExport/Writer/AttributeWriter.php#L52

But Product's fields from OroCommerce side are not in 'extend' scope https://github.com/orocommerce/orocommerce/blob/1.0.0-beta.5/src/Oro/Bundle/ProductBundle/Entity/Product.php#L378

So two configs appear in the database, extend proxy generated from 'extend' config and it differs from methods in Product's class. That's why notice appears.

I suggest you check configs from 'entity' scope.

from orocommerce.

You mean, this part :

<?php

            $entity->fromArray(
                'extend',
                [
                    'target_column'   => $target,
                    'target_entity'   => LocalizedFallbackValue::class,
                    'relation_key'    => RelationType::MANY_TO_MANY.'|'.Product::class.'|'.LocalizedFallbackValue::class.'|'.$entity->getFieldName(),
                    'target_grid'     => [
                        $target,
                    ],
                    'target_title'    => [
                        $target,
                    ],
                    'target_detailed' => [
                        $target,
                    ],
                    'cascade' => [
                        'persist',
                    ],
                    'without_default' => true,
                ],
                []
            );

Should have its first argument changed from extend to entity for system attributes ?

from orocommerce.

@gplanchat nope, the scope is valid here.

$provider = $this->configManager->getProvider('entity'); before https://github.com/synolia/oroneo/blob/9457f3748ac1d81d8cdff50d228d234dae65071a/ImportExport/Writer/AttributeWriter.php#L47 to check that property exists.

from orocommerce.

Thank you @SergeyZ, your hints and help drove me to the solution

I made the PR synolia/oroneo#7

from orocommerce.

@gplanchat You are welcome!

from orocommerce.