Giter Club home page Giter Club logo

Comments (9)

OrJDev avatar OrJDev commented on August 15, 2024 1

Interesting, thanks. The only change I had to make to get Discord working was the one described above (adding expires_in to the model) -- maybe things have changed a bit since you worked on it.

e4d74cf

also added a note for you so it will be easier next time

from create-jd-app.

OrJDev avatar OrJDev commented on August 15, 2024 1

it is not within @auth/solid-start itself.
it is within the new core of AuthJS, you could make an issue and ask why this happens at https://github.com/nextauthjs/next-auth

from create-jd-app.

AshSimmonds avatar AshSimmonds commented on August 15, 2024

Not a 100% authority but as far as I can tell this model has only been tested with github.

I had to do semi-significant changes to make Discord work, intend to PR them back but am travelling and mostly on mobile device. Search solidstart-17, I may or may not have pushed branch feature changes there can't recall.

from create-jd-app.

tmns avatar tmns commented on August 15, 2024

Interesting, thanks. The only change I had to make to get Discord working was the one described above (adding expires_in to the model) -- maybe things have changed a bit since you worked on it.

from create-jd-app.

OrJDev avatar OrJDev commented on August 15, 2024

Interesting, thanks. The only change I had to make to get Discord working was the one described above (adding expires_in to the model) -- maybe things have changed a bit since you worked on it.

Yes this is in the core of authJs, different providers require different models. This model is for google, github, etc

from create-jd-app.

OrJDev avatar OrJDev commented on August 15, 2024

Interesting, thanks. The only change I had to make to get Discord working was the one described above (adding expires_in to the model) -- maybe things have changed a bit since you worked on it.

e4d74cf

also added a note for you so it will be easier next time

Actually now the default provider is Discord as i don't see many People who use Github and it causes issues for people who want to use other Providers:

f1b3b0a

from create-jd-app.

tmns avatar tmns commented on August 15, 2024

Nice.. it does still strike me as a bit odd though that the Discord adapter seems to work in T3 (NextAuth) even without such a modification. Since it works there, I wonder if it's something that could be fixed in @auth/solid-start. 🤔

from create-jd-app.

OrJDev avatar OrJDev commented on August 15, 2024

it is not within @auth/solid-start itself.

it is within the new core of AuthJS, you could make an issue and ask why this happens at https://github.com/nextauthjs/next-auth

Actually here is the answer for this issue: nextauthjs/next-auth#6538 (comment)

from create-jd-app.

tmns avatar tmns commented on August 15, 2024

Yep stumbled across that afterward too. At the end of the day simply changing the model was the right suggestion to quickly get things working 👍

Notice though that the breaking provider in the linked issue there is Google. Indeed I originally saw this error happening with Google as well as Discord. However, I went back and tried again, and Google seemed to work even without expires_in 🤷‍♂️

from create-jd-app.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.