Giter Club home page Giter Club logo

Comments (8)

mmd-osm avatar mmd-osm commented on July 22, 2024 2

By the way, the HTTP error code will be 413 in this case, error message may differ from the one shown on the screenshot (e.g. something like zerebubuth/openstreetmap-cgimap#412 (comment) )

image

from organicmaps.

biodranik avatar biodranik commented on July 22, 2024

If someone travels offline, and then uploads changes back home, bbox can be big enough.

  1. Does it mean that a large bbox upload will be possible after 28 days (if repeated again)?
  2. Can you please try to reproduce this situation now with OM debug build, and record/check logs, and try again in 28 days to make sure that changes are finally uploaded? Maybe logs show that we don't support this kind of error properly, and the code should be updated.

from organicmaps.

mmd-osm avatar mmd-osm commented on July 22, 2024

Can you please try to reproduce this situation now with OM debug build

That's not yet possible, unless you're running your local Rails port for testing. Stay tuned for updates, at what point you can test it on the OSM dev instance.

from organicmaps.

RicoElectrico avatar RicoElectrico commented on July 22, 2024

If someone travels offline, and then uploads changes back home, bbox can be big enough.

Quote from the PR

and ramp up to the whole world over 28 days

In my understanding after 28 days it should succeed, relevant code: openstreetmap/openstreetmap-website@f61ac25#diff-1dd5a8f580b9615769ddc19a64a98f455d9d20eb149c443f41d9d3c797d39b12R183

That 5400000000 is (180+360)*1E6 degrees so the whole world.

from organicmaps.

deevroman avatar deevroman commented on July 22, 2024

doesn't Organic Maps load objects one at a time?

Then, after receiving error 429 on the next object, the edit package will be closed within an hour and Organic Maps will create a new one, for which it will be smaller.

from organicmaps.

RicoElectrico avatar RicoElectrico commented on July 22, 2024

doesn't Organic Maps load objects one at a time?

Indeed it does:

OsmOAuth::Response const response = m_auth.Request("/" + element.GetTypeString() + "/create",

from organicmaps.

mmd-osm avatar mmd-osm commented on July 22, 2024

We have deployed the new bbox size limit to https://master.apis.dev.openstreetmap.org ... please give it a try and report back any issues.

from organicmaps.

matkoniecz avatar matkoniecz commented on July 22, 2024

Then, after receiving error 429 on the next object, the edit package will be closed within an hour and Organic Maps will create a new one, for which it will be smaller.

Will OM retry in loop for that hour? Or will it wait on error response before retrying?

from organicmaps.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.