Giter Club home page Giter Club logo

Comments (6)

mchitre avatar mchitre commented on August 21, 2024

The call to pm.models() runs bellhop.exe with an empty env file. This is the expected behavior. But bellhop isn't supposed to terminate with a runtime error. On my machine, I get this back from Bellhop:

$ bellhop.exe test.env 
STOP Fatal Error: See print file for details

So I suspect this is to do with the version of Bellhop or with the compilation options. What version of Bellhop are you using?

Also, can you try running this in a new notebook:

import arlpy.uwapm as pm
import arlpy.plot as plt
import numpy as np

env = pm.create_env2d()
rays = pm.compute_eigenrays(env, model='bellhop')
pm.plot_rays(rays, env=env, width=900)

and see if it works...? This will skip the check for bellhop, and create a env file with proper content and run bellhop on it. It'll help us debug the problem.

from arlpy.

oliskir avatar oliskir commented on August 21, 2024

Hi mchitre, thanks for the quick answer! Yes, with a proper environment file, the code executes nicely. So the problem only occurs when the environmental file is empty. I get the same behaviour if I run bellhop.exe with an empty env file in the terminal, independent of your library.

from arlpy.

mchitre avatar mchitre commented on August 21, 2024

OK, probably a change in bellhop.exe behavior, or differences across platforms. Let me try and test with the latest version, and I'll update the mechanism to test availability of bellhop in the next release.

In the mean time, I presume you shouldn't be blocked, as you can just add the model = 'bellhop' to your uwapm calls, and it'll work fine without needing the detection.

from arlpy.

oliskir avatar oliskir commented on August 21, 2024

Yes, no urgency. I can continue working in the mean time.

Unrelated to this, I was wondering if you have plans to implement 3d environments and execution of bellhop3d?

from arlpy.

mchitre avatar mchitre commented on August 21, 2024

I haven't explored the file formats for Bellhop 3D since I don't use it, but they shouldn't be that different. It will likely be useful someday for me, and so I'll be happy to implement it if there's interest by others in using it. If you feel that you'll find value in it, do raise a feature request and I'll attend to it as soon as I get some time.

from arlpy.

mchitre avatar mchitre commented on August 21, 2024

Hopefully fixed. I can't test since I don't seem to be able to replicate the issue, but it now uses a non-existent file instead of an empty file, and at least on OSX, that seems to print an error message and gracefully terminate.

from arlpy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.