Clean-up: is this `try_color_from_string` redundant? about gping HOT 3 CLOSED

Hey! Yeah I’m definitely in favour of doing this if possible. This would be a great clean up 🧹. This code was added before ratatui existed, and if they have the same functionality then we should use it.

Regarding the differences in name conventions, we could add a switch statement to convert “light-red” to “lightred” or make a PR to add these aliases to ratatui?

from gping.

The difference in the error caption:

ratatui: Failed to parse Colors
gping: Invalid color code: `{}`

This error is easy to wrap & handle:

error => Some(error.map_err(|err| {
    anyhow!(err).context(format!("Invalid color code: `{}`", name))
})),

> ./gping www.google.com www.baidu.com -c "red,yello"                                       07/10/2023 03:32:12 PM
Error: Invalid color code: `yello`

Caused by:
    Failed to parse Colors

Or even simpler:

_ => Some(Err(anyhow!("Invalid color code: `{}`", name))),

> ./gping www.google.com www.baidu.com -c "red,yello"                                     1 07/10/2023 03:32:17 PM
Error: Invalid color code: `yello`

Which case would like @orf?

The difference in the color name conventions:

ratatui: "lightred" | "light red"
gping: "light-red"

from gping.

Hey! Yeah I’m definitely in favour of doing this if possible. This would be a great clean up broom. This code was added before ratatui existed, and if they have the same functionality then we should use it.

Regarding the differences in name conventions, we could add a switch statement to convert “light-red” to “lightred” or make a PR to add these aliases to ratatui?

I'm not sure because the naming convention may not be a standard for the framework, we can definitely work around it by replacing the -, and I'll try to ask for opinions from upstream~

Personally, I believe ratatui is not very mature in this part, because some same colors can have different expressions in their enum model. That would be way too much to discuss.

from gping.