Comments (8)
I now read the section in the NURBS book on these two circle constructions
The way I interpret it is that the 7 point circle construction is worse than the 9 point circle - due to two factors:
- the parameterisation leads to a less regular interpolation (this can be seen looking at the figures)
- the convex hull is looser
I guess the detail is in the discussion of higher order circles (later in the same chapter) and discontinuities in the basis functions.
from geomdl-shapes.
Seems like it is working fine but there is an important fine print here: it is not possible to generate a correct full circle using 7 control points. It will be always 3 arcs connected together. The NURBS Book also says the parameterization is not as good as the 9-point full circle.
That was a fun experiment for me at the time of the development, but considering today, I think it is best to remove curve2d.full_circle2
to avoid confusion.
The reference for 7-point full circle is on pages 301 and 302 of The NURBS Book, 2nd Edition.
from geomdl-shapes.
actually 7 point is possible - see the later comment.
orbingol/NURBS-Python#67 (comment)
from geomdl-shapes.
@cshorler I still don't believe that is a valid full circle. Using 9-points makes sure that you are creating the correct full circle at all times.
I think it would be the best to contribute that script to the examples repo.
from geomdl-shapes.
I also made some changes to the remaining function for compatibility with the 6.x branch.
Also - when developing the package name conflicts with a parallel (egg link) install of NURBS-Python / geomdl. I can submit a PR for this as well.
from geomdl-shapes.
geomdl-shapes will be merged with 6.x along with a couple of example curves, surfaces and volumes from the examples repository. It will still be maintained for 5.x
from geomdl-shapes.
Also - when developing the package name conflicts with a parallel (egg link) install of NURBS-Python / geomdl. I can submit a PR for this as well.
I'd be glad if you could open a new ticket for this.
from geomdl-shapes.
Also - when developing the package name conflicts with a parallel (egg link) install of NURBS-Python / geomdl. I can submit a PR for this as well.
I'd be glad if you could open a new ticket for this.
okay will do
from geomdl-shapes.
Related Issues (3)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from geomdl-shapes.