Giter Club home page Giter Club logo

Comments (2)

iamstolis avatar iamstolis commented on September 24, 2024 1

This is a misunderstanding. Note that the help/documentation of the option says

--js.allow-eval=true|false   Allow or disallow code generation from strings, e.g. using eval(). 

Your example invokes eval() with a number argument. When eval() is invoked with non-string argument then this argument becomes the return value (and no "code generation from string" occurs). Try eval("600+16") instead of eval(600+16) to see the difference.

from graaljs.

mrivas616 avatar mrivas616 commented on September 24, 2024

This is a misunderstanding. Note that the help/documentation of the option says

--js.allow-eval=true|false   Allow or disallow code generation from strings, e.g. using eval(). 

Your example invokes eval() with a number argument. When eval() is invoked with non-string argument then this argument becomes the return value (and no "code generation from string" occurs). Try eval("600+16") instead of eval(600+16) to see the difference.

Wow, I can't believe I missed that. I totally get what the doc says now, thank you! I don't know if it'd be worth adding examples to the doc to avoid this kind of misunderstandings, although I think my ESL is what's mostly to blame.

For all intents and purposes if eval cannot evaluate strings, that should be enough to satisfy my "disallow using eval" requirement as I can't come up with a scenario where evaluating non-string arguments with eval might result in a security concern, as usual though, there might be.

Anyways, thank you again, I appreciate the clarification :)

from graaljs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.