issue: Incorrect client engine detected about javascript-sdk HOT 4 CLOSED

Hi @jasonrowsell , optimizely-sdk specifies three entry points in the package.json

"module": "dist/optimizely.browser.es.min.js",
"main": "dist/optimizely.node.min.js",
"browser": "dist/optimizely.browser.min.js",

As you can see, module and browser fields point to browser entrypoints, and the main field points to node entrypoint.
Looks like we need to add

module.exports = {
  //...
  resolve: {
    mainFields: ['main', 'module'],
  },
};

to the webpack config.

According to webpack documentation, if we use node target, then the default value for resolve.mainFields is ['module', 'main'], which will resolve to the browser entrypoint for optimizely-sdk. Adding the above config should make webpack resolve to the node entrypoint instead.

from javascript-sdk.

Worked like a charm, no more errors logged. Thank you very much for your help and such a quick response :)

from javascript-sdk.

Hi. Thanks for reporting the issue. We are looking into it.

A question:
Are you using any bundler? In that case, are you bundling for proper target? For example: setting target: 'node' for webpack?

from javascript-sdk.

Hi @raju-opti, webpack is used for the bundler and the target is set to node

module.exports = {
  mode: serverlessWebpack.lib.webpack.isLocal ? "development" : "production",
  entry: serverlessWebpack.lib.entries,
  resolve: {
    extensions: [".js", ".ts"]
  },
  optimization: {
    minimize: false
  },
  output: {
    libraryTarget: "commonjs2",
    path: path.join(__dirname, ".webpack"),
    filename: "[name].js"
  },
  externals: {
    "aws-sdk": "aws-sdk"
  },
  target: "node",
  module: {
    rules: [{ test: /\.ts/, loader: "ts-loader" }]
  },
}

from javascript-sdk.