Comments (6)
Sorry for being late to the party, but after looking through the code and what the results are of importing that repo (at least for me), it appears there was a bug introduced to the submodule logic when the refactor happened. Specifically the else statement was removed from this conditional https://github.com/operatorequals/httpimport/blob/master/httpimport.py#L439
This causes it to assume the __package__
attribute to be the full module name, which breaks relative imports on submodules which are 2nd level submodules (i.e. package.module). The else statement needs to be added back which sets the package attribute like this mod.__package__ = name.split('.')[0]
though with the new code it would be pkg_name.
from httpimport.
@rkbennett Would you provide a pull request with the fix, that would be great.
from httpimport.
Done
from httpimport.
Hey @cforce 🙃
I really don't see what this happens in first glance.
Can you provide the version of the module you are using?
from httpimport.
i am using the latest of everything
from httpimport.
I'm here to review and merge a PR (and cut a release), but it would take a bit more for me to develop the fix, as I currently am not into computers all that much!
Cheers @rkbennett for finding tje culprit, I didn't have the time and energy to debug.
from httpimport.
Related Issues (20)
- Old module is imported when online file is changed HOT 2
- I encountered the following error when using the prompt HOT 1
- Support packages with shared object files HOT 2
- New version 0.9.2 breaks loading of joblib pickled model HOT 5
- Relative Path Importing/incorrect import package HOT 2
- Add support for module import directly from PyPI HOT 1
- Problem in Google Colab HOT 4
- Support Gitea Service
- Code to import from gist now breaks with AttributeError: 'list' object has no attribute 'endswith' HOT 5
- attribute error module 'passman' has no attribute 'list_profiles' HOT 2
- Support for Gitlab private repos HOT 9
- import public github HOT 4
- How do I import from private github repo? HOT 3
- can't access private repo from github HOT 4
- Not supported from package.module import class HOT 9
- PyPIImporter should be able to use proxy
- Python 3.12 Support HOT 2
- Load a python script that contains a main function HOT 13
- Importing libraries with different installation name
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from httpimport.