Comments (4)
Hey @fedor57 ,
So far with all implementations we have the endpoint set as part of the server side integration code.
This does not mean however that we should fail with NullPointerException
at client side when endpoint has not been set. This should get fixed.
I also agree that we should be able to start a span from server or client side. Currently it looks like we have a dependency on the server side.
The X-B3-Span-Name
header was introduced by me and had the purpose of aligning client/server side snap names. If a span name was created at client side which was not easily derivable at server side passing the name and re-using it at server side was a way to solve this. However I'm thinking of abandoning this approach and choosing simple span names, see #59.
I want to spend some time soon on the work needed for brave 3.0 and I'll take these 2 issues + documentation into account.
from brave.
Thanx, Kristof. I have answered on service/span naming on #59, regarding the correct approach for clients:
If current request had no instrumentation but the current module had a Zipkin library attached with client requests instrumented we should start a span automatically. No point in having "cs" without parent-span-id and break 3 client calls into different traces.
But theoretically there is a case when it shouldn't. Imagine you have a testing utility that fires 1000 requests from logs from different clients.
If we autostart the span it should start at least at the beginning of the first call and end at least at the end of the last.
But also we should be able to mark the beginning earlier and end later.
For the IP call we can use not Start/Done, but call some annotation method like AddAnnotation("Start"), AddAnnotation("End") - so those does not assume that current span exists or not, but makes sure that it will exist after the call. Or we can use AddAnnotation() without parameters that just checks the the current moment belongs to some span.
There is a problem with end of the span if no "ss" interceptor will be fired. So if I don't call Done - the trace is created but the current span is never finished. Maybe this to be considered - to autoclose span after timeout and mark it somehow?
from brave.
@fedor57 This issue should be fixed with brave 3.0.0-rc-1.
from brave.
Fixed. EndpointSubmitter does not exist anymore. No need to submit endpoint upfront.
from brave.
Related Issues (20)
- Trace id is not Propagating to called service
- Support spring-webmvc for jakarta HOT 3
- Kafka Streams Tracing does not continue the trace HOT 1
- Local correlation fields not logged
- Support OTLP format of span reporting HOT 1
- Wrapped Runnable and Callable should delegate toString() HOT 1
- TracingClientHttpRequestInterceptor.java in Brave 4 requires HttpTracing which is available starting brave 5 HOT 1
- Switch from javax.* to jakarta.* HOT 1
- Kafka streams processor tracing support on context.forward HOT 17
- ArrayIndexOutOfBoundsException from MutableSpan HOT 8
- flakey test: brave.jms.ITJms_2_0_TracingMessageConsumer HOT 2
- flakey test: brave.kafka1.clients.ITKafkaTracing.poll_creates_one_consumer_span_per_topic
- change dependency priority on spring-beans
- ci: PR tests take too long (17m) HOT 2
- Support spring 6 HOT 6
- Excessive allocations ExtraFactory.decorate HOT 10
- Instrumentation for Apache Thrift HOT 1
- VirtualThread pinning with RealSpan and zipkin2.reporter HOT 7
- MutableSpan.clone isn't implemented HOT 1
- Support MongoDB client version 5.x HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from brave.