Giter Club home page Giter Club logo

Comments (4)

kelson42 avatar kelson42 commented on June 10, 2024

@Skylsmoi @lebouquetin I finally have merged the code after the last modifications. Unfortunately, it seems something does not apply correctly. Just an example with the article "Lyon" https://fr.wikipedia.org/wiki/Lyon, if you have a look at the bottom of the infobox on the right, you see the map, with the links allowing to change the map dynamically. This is typically what I think should also work now, but it does not (I see only the 3 pictures on, just after the other - like before the patch).

from mwoffliner.

lebouquetin avatar lebouquetin commented on June 10, 2024

@kelson42, @Skylsmoi has investigated. Actually, the api.php endpoint does not return all modules required by the page. We need to load/parse the head of the page which includes a hard-written call to mw.loader.load(). It sounds like api.php content is not exhaustive and so we need to use both.

from mwoffliner.

kelson42 avatar kelson42 commented on June 10, 2024

@Skylsmoi @lebouquetin Thx for having taking a look quickly to that. If we try to focus on the "Lyon example" what is exactly missing? Which module name?

Maybe there is an other explanation: Mediawiki has also std css/js content which apply to all pages (and which are I suspect not managed through the resource loader) like:

And also the "vector" skin:

There is also the custom offline css:

Might that be that these things are not anymore managed correctly?

from mwoffliner.

kelson42 avatar kelson42 commented on June 10, 2024

After many efforts it seems to me that what could reasonably be done has been done. mwoffliner can download efficiently dependencies on an article base. In addition it takes in account correctly the old/std js and css articles (commons.css, common.js, ...). That said the solution still suffers from weaknesses due to dynamic loading within the modules (not supported yet in mwoffliner) and many other small problems which impact in a way or another the offline UX.

from mwoffliner.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.