Comments (4)
@Skylsmoi @lebouquetin I finally have merged the code after the last modifications. Unfortunately, it seems something does not apply correctly. Just an example with the article "Lyon" https://fr.wikipedia.org/wiki/Lyon, if you have a look at the bottom of the infobox on the right, you see the map, with the links allowing to change the map dynamically. This is typically what I think should also work now, but it does not (I see only the 3 pictures on, just after the other - like before the patch).
from mwoffliner.
@kelson42, @Skylsmoi has investigated. Actually, the api.php endpoint does not return all modules required by the page. We need to load/parse the head of the page which includes a hard-written call to mw.loader.load(). It sounds like api.php content is not exhaustive and so we need to use both.
from mwoffliner.
@Skylsmoi @lebouquetin Thx for having taking a look quickly to that. If we try to focus on the "Lyon example" what is exactly missing? Which module name?
Maybe there is an other explanation: Mediawiki has also std css/js content which apply to all pages (and which are I suspect not managed through the resource loader) like:
- https://fr.wikipedia.org/wiki/MediaWiki:Common.js
- https://fr.wikipedia.org/wiki/MediaWiki:Common.css
And also the "vector" skin:
- https://fr.wikipedia.org/wiki/MediaWiki:Vector.css
- https://fr.wikipedia.org/wiki/MediaWiki:Vector.js
There is also the custom offline css:
Might that be that these things are not anymore managed correctly?
from mwoffliner.
After many efforts it seems to me that what could reasonably be done has been done. mwoffliner can download efficiently dependencies on an article base. In addition it takes in account correctly the old/std js and css articles (commons.css, common.js, ...). That said the solution still suffers from weaknesses due to dynamic loading within the modules (not supported yet in mwoffliner) and many other small problems which impact in a way or another the offline UX.
from mwoffliner.
Related Issues (20)
- Unexisting image keys are requested to the S3 cache HOT 1
- Some maps images can not be download from bm.wikipedia.org
- Unable to execute 'npm ci' or 'npm install command HOT 3
- Open link in new tab. Kiwix extension in Firefox. HOT 3
- Collapsed tables are not viewable HOT 1
- Unable to find appropriate API end-point to retrieve article HTML HOT 4
- summary and details tag are no longer supported HOT 2
- Make sure format option is working for WikimediaMobile renderer HOT 5
- MWoffliner should support latest mediawiki release HOT 2
- What the role of `res/inserted_style.css` HOT 12
- Define title param (article_id) role for Wikimedia REST API offline resources
- Release 1.14.0
- wikipedia_en_all_mini is the same as _nopic HOT 1
- Refactor mwoffliner logic behind CSS/JS modules handling HOT 3
- Raw HTML and html entities appearing in directory entry title field HOT 3
- Images from page/mobile-html endpoint are too big HOT 6
- Full article URL calculates two times in different parts of mwoffliner using different funtions HOT 2
- nopdf param doesn't work as expected for some articles
- Apply test coverage for all endpoins
- Zimcheck failing for some articles HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mwoffliner.