Giter Club home page Giter Club logo

Comments (2)

tarelli avatar tarelli commented on August 16, 2024

@gidili any update?

from org.geppetto.

gidili avatar gidili commented on August 16, 2024

Some thoughts about this after investigating for a while.

Assumption is that we want to add hooks same as the other buttons on GEPPETTO.FE.js for the zoom/pan controls and re-route those to console commands like:

$('#start').click(function() {
   GEPPETTO.Console.executeCommand("Simulation.start()");
});

It looks like at the moment camera controls are initialised in GEPPETTO.init.js and then the camera position is updated in GEPPETTO.js by the updateCamera function.

The updateCamera function is then called by hooks to the rotate/pan/zoom buttons setup in GEPPETTO.init.js.

An option to refactor this would be pulling the rotate/pan/zoom functions into a "Camera" client side object. Creating this object would be nice if we can pull all camera related stuff in it - not just rotation/pan/zoom hooks but everything including init stuff.

As I look for camera related stuff, there is quite a bit of stuff in various places (GEPPETTO.js / GEPPETTO.init.js). This camera refactoring seems like a good thing to do definitely, but it also seems like a bigger task (creating this new object and making sure there's no camera manipulation happening outside of it) than just wrapping the hooks to the buttons and re-routing them to console actions.

Thoughts? @tarelli @jrmartin @mlolson

from org.geppetto.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.