Giter Club home page Giter Club logo

Comments (2)

davidz25 avatar davidz25 commented on August 16, 2024

Yeah, I believe we don't have proper error checking here... as we get around to adding support for 18013-7 (which will have a version number > 1.0) we'll get around to fixing this.

from identity-credential.

davidz25 avatar davidz25 commented on August 16, 2024

I think the library supports everything you need, that is

  • DeviceRequestParser.DeviceRequest has a getVersion() method which conveys the version string in DeviceRequest CBOR
  • DeviceResponseGenerator has a way for the application to set the status code which will appear in the DeviceResponse CBOR

Our reference mdoc app however is always using DEVICE_RESPONSE_STATUS_OK. We should fix that so it's returning DEVICE_RESPONSE_STATUS_GENERAL_ERROR (status 10) if version isn't "1.0" or "1.1".

from identity-credential.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.