[Good First Issue]: Enable CompiledModel set/get property() about openvino HOT 16 OPEN

Hi @nashez, the issue is still under development. I have everything implemented but this test for set_property(). I'm waiting for a response to my issue.

from openvino.

@almilosz I found that if you change 1 in cm.set_property({'AUTO_BATCH_TIMEOUT': 1}) to be a string it doesn't throw error so I guess there is a problem with converting this variable under the hood.

Is it enough reason for not exposing auto_batch_timeout in this issue?
Should I also create separate file for testing compiled_model?

Thank you for your hint!

Poznań? Never heard of it ;)
Must be like a GitHub project - constantly under 'maintenance' with occasional surprise updates.

from openvino.

.take

from openvino.

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

from openvino.

Hello @Aryan8912, there are currently three issues with open PRs assigned to you. Please finish them before picking more tasks.

from openvino.

hello, Is it possible being assigned to this issue?

from openvino.

.take

from openvino.

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

from openvino.

hey @Plomo-02 do you need any help?
will you have a time to continue work on this task?

from openvino.

.take

from openvino.

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

from openvino.

Hi @almilosz @vishniakov-nikolai, I have encountered an issue while testing the implementation of CompiledModel::set_property()

  Exception from src/inference/src/cpp/compiled_model.cpp:136:
  Exception from src/plugins/intel_cpu/src/compiled_model.h:39:
  Not Implemented:
  It's not possible to set property of an already compiled model. Set property to Core::compile_model during compilation

It seems like there is a template:

But only one plugin implements that:

Other have:

My implementation so far:

Napi::Value CompiledModelWrap::set_property(const Napi::CallbackInfo &info) {
    Napi::Env env = info.Env();
    try{
        if (info.Length() != 1 || !info[0].IsObject()) {
            OPENVINO_THROW("Expected a single object argument for setting properties");
        }
        const auto properties = to_anyMap(env, info[0]);
        _compiled_model.set_property(properties);
    }catch (const std::exception& e) {
            reportError(env, e.what());
    }
    return env.Undefined();
}

My question

How should I test it?

from openvino.

@hub-bla @mlukasze Is this still under development?
If not can I take this up?

from openvino.

Hi @hub-bla!
Thanks for taking this issue.
CompiledModel::set_property() can be tested in Python like this:

timeout = 10
cm = core.compile_model(model, "BATCH:CPU")
cm.set_property(props.auto_batch_timeout(timeout))
assert timeout == cm.get_property('AUTO_BATCH_TIMEOUT')

To do that in Node.js API you will have to expose ov::auto_batch_timeout additionally, which may require more work.

Alternatively, you can wait as we look into the reasons why the option below is not working:

cm.set_property({'AUTO_BATCH_TIMEOUT': 1})

Let me know what you decide to do. If you have any questions, don't hesitate to ask them. You can reach me on Discord _almilosz and ask directly.

Greetings from Poznań,
Alicja

from openvino.

Yes, please create a test like this in a new file compiled_model.test.js file
Exposing properties will be a separate issue :)

from openvino.

I looked into the problem with conversion and I think I found the reason why.

from openvino.