WebsocketAutoConfiguration should be conditional on class WebSocketMessageBrokerConfigurationSupport about java-spring-cloud HOT 7 CLOSED

@mdvorak Thanks for reporting this - would you be interested in submitting a PR?

from java-spring-cloud.

This is the second issue associated with this auto-config. Issue #74 and fix #75. @objectiser could you please look at it?

@mdvorak what is your classpath for me this artifact works if websocket is not present. A reproducer would be handy.

from java-spring-cloud.

Will get back to it, be patient, thanks

from java-spring-cloud.

Looking at the dependencies in the cloud-starter with the two profiles:

[gbrown@localhost opentracing-spring-cloud-starter]$ mvn -Palldeps dependency:tree | grep websocket
[INFO] |  |  \- org.apache.tomcat.embed:tomcat-embed-websocket:jar:8.5.23:test
[INFO] \- org.springframework.boot:spring-boot-starter-websocket:jar:1.5.8.RELEASE:test
[INFO]    \- org.springframework:spring-websocket:jar:4.3.12.RELEASE:test
[gbrown@localhost opentracing-spring-cloud-starter]$ mvn -Pnodeps dependency:tree | grep websocket
[INFO]    |  \- org.apache.tomcat.embed:tomcat-embed-websocket:jar:8.5.23:test

I would have expected this issue to have occurred in the nodeps profile?

from java-spring-cloud.

Some work is required to support spring-boot 2 (see #111), but was able to run the cloud-starter tests against SB 2 and still didn't show up the issue.

Ran the following from the opentracing-spring-cloud-starter module:

mvn clean test -Dversion.org.springframework.boot=2.0.0.RELEASE -Pnodeps

from java-spring-cloud.

@mdvorak do you have any update? Maybe dependency tree of your project could help us to solve this.

from java-spring-cloud.

Problematic case is when you have only these three dependencies (tested with 1.5.11.RELEASE):

<dependency>
    <groupId>org.springframework.boot</groupId>
    <artifactId>spring-boot-starter-web</artifactId>
</dependency>
<dependency>
    <groupId>org.springframework</groupId>
    <artifactId>spring-messaging</artifactId>
</dependency>
<dependency>
    <groupId>io.opentracing.contrib</groupId>
    <artifactId>opentracing-spring-cloud-starter</artifactId>
    <version>0.1.7</version>
</dependency>

and nothing else. #112 fixes this. Thanks @objectiser for the PR.

PS: Sorry for long response, I had another work engagement.

from java-spring-cloud.