Global variables are being rewritten about opentok-node HOT 4 CLOSED

Update: I have changed "options =" to "var options =" (line 233) and "req =" to "var req =" (line 244) and it now works perfectly.

from opentok-node.

If this is resolved, then you can close the issue, right?

from opentok-node.

I do not know if this is resolved or not, I haven't updated Opentok api. Opentok developers should not make any variables global in their modules. If this is resolved, there should be an answer from them. However, here is absolutely no answer for 4 months.

from opentok-node.

@igorpavlov sorry about the silence regarding the issue. i can admit we have room for improvement in terms of monitoring external feedback on these SDKs. thanks for taking the time to try and help improve it with your feedback.

in this particular instance i don't see any issues with the code (the changes you suggested are now in the repo). but even before then, i'm not sure there would have been any issue. even if options and req were not defined with var, that should at most be visible in the current file opentok.js. you shouldn't be writing any additional code in that file, only including it using npm and require('opentok'). so it would be impossible for these variables to leak to your express app.

from opentok-node.