DropZone2 (used in grid view) doesn't enforce correct object type about openstudioapplication HOT 5 OPEN

@DavidGoldwasser can you expand on the issue here? The API already restricts the setInsideShelf method to take an InteriorPartitionSurface and the setOutsideShelf to take a ShadingSurface:

https://github.com/NREL/OpenStudio/blob/develop/openstudiocore/src/model/DaylightingDeviceShelf.hpp#L69

from openstudioapplication.

Looks like the API enforces it but not the GUI. On screenshot below it accepts any kind of surface or sub-surface, although I did just confirm that if I leave the tab and come back, it disappears. On screenshot below I added a sub-surface as an outside shelf. Seems like it should only accept an interior partition surface or a sharing surface. @macumber does the API enforce outside as shading and inside as interior partition, or can they both take either? Whichever way the API is the GUI should match.

from openstudioapplication.

Ok, switching this over to @evanweaver then

from openstudioapplication.

I renamed after realized it wasn't related daylighting shelf, but happens elsewhere in GridView. Still a minor issue because it doesn't do anything wrong to the model. Below is another example where i dropped a schedule set instead of a construction set. No reason to fix this for 1.10. If there isn't easy fix for this issue we could improve the description in daylighting shelf columns to show what kind of object it expects, it isn't as obvious as it is elsewhere.

from openstudioapplication.

I can reproduce the "drop schedule set" inside the "construction set" area in 2.2.1. Interestingly, the drop only works if It's already in "My Model" and I'm dragging from "My Model". The drop doesn't work when I drag from the Library.

from openstudioapplication.