Comments (2)
I don't think the added complexity is worth it here. Either these are errors which can actually happen in real life in which case we must handle them. Or they are not, which I think is the case here. But then doing the simplest thing is enough to get at least something when testing or so. And that's what we have. We can spend forever coming up with scenarios how this can all fail, but at some point we have to ask ourselves whether it is worth it.
from osmdbt.
I see that those errors are currently printed to stderr, so they're no totally lost:
} else if (parts[2] == "X") {
std::cerr << "Error found in logfile: " << line << '\n';
I think the basic question here is, what would a sysadmin do with those messages? Would they be part of some monitoring, or disappear into void?
At least the elog warnings would also appear as Warning in the Postgresql log files, where they might be easier to consume for an automated monitoring. Unfortunately, I'm not aware of any guidelines here, so this may all a bit theoretical after all.
from osmdbt.
Related Issues (20)
- disable-replication should check for remaining entries to be processed HOT 2
- Limit total number of changes per diff generation (osmosis compatibility) HOT 10
- Q: fake-log process and duplicates in diff files HOT 6
- launchpad.net Ubuntu PPA build HOT 23
- Unit test for relations table HOT 2
- Unit tests for create-diff HOT 5
- Exploring wal2json HOT 2
- Should get-log check for existing log files with same LSN? HOT 1
- Fetching objects in create-diff (osmosis performance regression) HOT 2
- fake-log, isolation level and concurrent txns HOT 4
- state.txt timestamp - and osmosis compatibility HOT 2
- Order of tags in object HOT 4
- Docker compose cluster HOT 1
- Merging diff files HOT 2
- Documenting state.txt file format HOT 2
- CI is broken HOT 4
- Build for Ubuntu 22.04 HOT 3
- osmdbt and pgoutput HOT 2
- osmdbt and first minute diff HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from osmdbt.