Refactor usage of check_api_readable/writable about openstreetmap-website HOT 2 CLOSED

Fixed by #4859

from openstreetmap-website.

Just as a passing comment here - in #4859 I managed to extract check_api_readable into api_controller (since it applies by default to most controllers).

I thought about doing something similar with check_api_writable, since there's a frequent pattern of:

before_action :check_api_writable, :only => [:create, :update, :destroy]

I think this could apply by default to all api controllers - for those action names, you probably want to check the database is writeable by default.

What stands in the way is that many of our api controllers aren't (yet) refactored to use resourceful routing - they have idiosyncratic action names like :subscribe or :update_all. This is another place where resourceful routing refactoring, although a substantial amount of work, would prove useful in making the code easier to maintain and to build new features.

from openstreetmap-website.