Giter Club home page Giter Club logo

Comments (9)

1ec5 avatar 1ec5 commented on September 26, 2024 1

Correct. In that case, iD will advise the user to enable the boundary layer if they really want to move or delete the shared node. This is preferable to munging a boundary they might not even notice because of an overlapping feature. There’s considerable debate about what can legitimately be connected to a boundary, if anything, but this request is specifically intended to prevent mistakes that can arise even when there’s consensus that something should be connected.

One possible downside is that we might start to get questions on the forum along the lines of: I wanted to edit a boundary I see on [osm-carto], but I can’t see it when opening [iD]. Hopefully the “n hidden features” indicator in the status bar will clue in some mappers though.

from openstreetmap-website.

tomhughes avatar tomhughes commented on September 26, 2024

Surely disabling boundaries is just as dangerous, if not more so, as you can wind up editing something that you don't even know exists if it shares nodes/ways with other features?

from openstreetmap-website.

matheusgomesms avatar matheusgomesms commented on September 26, 2024

Surely disabling boundaries is just as dangerous, if not more so, as you can wind up editing something that you don't even know exists if it shares nodes/ways with other features?

Doesn't iD block editing any feature when a boundary is connected to it but is invisible?

from openstreetmap-website.

AntMadeira avatar AntMadeira commented on September 26, 2024

That or produce an info box stating that boundaries should only be edited with caution and after activating the boundary layer.

One possible downside is that we might start to get questions on the forum along the lines of: I wanted to edit a boundary I see on [osm-carto], but I can’t see it when opening [iD]. Hopefully the “n hidden features” indicator in the status bar will clue in some mappers though.

from openstreetmap-website.

AntMadeira avatar AntMadeira commented on September 26, 2024

Surely disabling boundaries is just as dangerous, if not more so, as you can wind up editing something that you don't even know exists if it shares nodes/ways with other features?

Doesn't iD block editing any feature when a boundary is connected to it but is invisible?

Yes, it does.
So, it's just a matter of disabling that layer by default.

from openstreetmap-website.

mmd-osm avatar mmd-osm commented on September 26, 2024

So this issue mainly talks about new users, and at the same time defines a default that applies to everyone. This feels a bit inconsistent to me. How should this work for experienced users? Should they be able to override this default, if so, how?

from openstreetmap-website.

matheusgomesms avatar matheusgomesms commented on September 26, 2024

Should they be able to override this default, if so, how?

The same way it exists now: enabling it in the menu (right side menu, Map Data, Map Elements).

The idea is that this option is disabled by default, but once the user enables it, then it gets enabled forever (saved in the user's preference), as it happens as of today.

from openstreetmap-website.

mmd-osm avatar mmd-osm commented on September 26, 2024

Right, iD does not store this information in the user's preferences, but in the browser's Local Storage (underneath the "disabled-features" key). If we would forcefully disable the boundaries when calling iD (by setting some URL hash parameter), it then really depends which of these two settings takes precedence. It would be bad if we'd be constantly overruling whatever the user has decided for themselves. Has anyone already tried out how iD behaves in that case?

By the way, if the goal is to update some user preferences when toggling the boundaries flag in iD, that would need some support from iD side as well.

For avoidance of doubt, when i talk about user preferences, I'm referring to https://wiki.openstreetmap.org/wiki/API_v0.6#Preferences_of_the_logged-in_user:_GET_/api/0.6/user/preferences

from openstreetmap-website.

tordans avatar tordans commented on September 26, 2024

The goal is IMO that all users that have no other settings specified for iD (wherever iD stores them) has smart defaults and one of those smart defaults is to disable boundaries. The few users that know what they are doing (in regards to boundaries) will find the filter and enable the boundaries manually.

However, I agree with Tom from 2021 that those changes are something that the iD Maintainer would ideally look into.

from openstreetmap-website.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.