Giter Club home page Giter Club logo

Comments (1)

1231231231231231231231231 avatar 1231231231231231231231231 commented on June 21, 2024

After opening iD in a new tab as mentioned, I thought maybe copying over the oauth2 token to the initial tab would work. However, the value was now already there (I guess iD filled it in the background and the localStorage data is not tab-specific). Pressing save now worked normally (changeset 151644198).

I'm not sure if you have any idea how to find out what caused this token value to be empty, but:

  • it should always be possible to download your changes. Honestly I found this to be the scariest bit. Bugs can always occur, but unless JS stopped executing on the page altogether, you should be able to just 'have' your work somehow -- and perhaps it should be possible even then via localStorage.
    Perhaps this download option should be given its own shortcut (that one can find in docs somewhere when the UI breaks) and/or be additionally linked from the existing "Map Data" side panel? I think both options would have worked in my case.
  • the browser pop-up window suggests to me the situation is intended to be recoverable; that this pop-up should request a new token from OSM. Perhaps this broke during a recent oauth2 code change?
  • why did the new browser tab not offer to restore the edit? (I also traced the code for this history saving thing to find how to force that pop-up, but did not find any function or UI that I could trigger from the global scope.)
  • more minorly, the UI should not break. Besides that pop-up showing an error, the UI of iD itself also broke. I guessed that pressing Esc would close the sort-of-opened Save UI and it did, so I could retry, but this should not be necessary. Perhaps it should show a "auth token missing, see the pop-up" overlay that you can click away?

from id.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.