"Best image" should be aerial, not other categories about id HOT 5 CLOSED

What are your concerns in adding this check in iD/Rapid?

If the data is set up wrongly in the source, it should be fixed there, not by the imagery consumers.

best does have a well defined meaning, (it's a local override to the global Bing default), and it shouldn't be set for a source that's not orthoimagery for tracing.

from id.

I marked this as "good first issue" because I assume that the part of the code that handels the layer that is selected by default should be straight forward to find and adjust as described above. But I did not look into it myself, yet.

from id.

This is an issue for editor-layer-index, not iD

from id.

This is an issue for editor-layer-index, not iD

@bhousel Only if ELI defines that the "best" option should only be applied to aerial imagery. The Alkis layer is in fact the best of it's category.

I don't think it unreasonable to specify a "best" per category.

Unfortunately, ELI's documentation on the topic of category and "best" ist not that extensive.

What are your concerns in adding this check in iD/Rapid?

from id.

@bhousel thanks for your insight. I do not consider the best flag well documented and as such defined. But I agree with your definition and will try to find the time to suggest upstream changes to improve the docs and fix the wrong usage. I now remember that I ran into the same issue 2018 but that staled in its research state osmlab/editor-layer-index#538.

Note to self: This https://github.com/osmlab/editor-layer-index/blob/gh-pages/schema.json#L109-L112 will also have to change to clarify the intended usage of "best" as "local override to the global Bing default".

I will close this issue here.

from id.