Comments (3)
It's not clear to me what this means. Please expand on this issue / feature request. Thank you.
from release-tools.
At the end of the release process there was a requirement to have individuals +1 the PRs (not necessarily approvers) and there was confusion on who was doing it, which they were doing, whether they were duplicating it, etc.
It would make sense to have a simple script into which you input names (emails) which generates PR URLs for those email-users to click on and +1 (while there was not a huge amount of PRs, there may also be more in future). This script could also include an 'expected diff' since on one hand we have already reviewed the changes to get to this point, and the +1 is in essence a tip of the hat, there should be SOME sanity check. This expected diff "example" should be minimal since it is just a branch/release switch/cut.
This could be part of the larger "release" script which was suggested in another issue.
from release-tools.
Ah ok. So, we discussed whether or not to pursue automatic CR voting on the batch and decided against it. ie. The bot can vote on tests, but should not do code-review voting.
Whether a human is comfortable with scripting an iterative code-review plus-vote is a different debate, and may or may not be desired per-individual.
I don't think we should script it.
from release-tools.
Related Issues (20)
- update-stable-charms/stable-branch-updates are not always pinning charms.openstack HOT 1
- batch-example should copy global/*/.zuul.yaml into the charms
- glance charm currently requires a custom test-requirements.txt HOT 1
- Ensure that fixture charms in bundles don't updated to ~openstack-charmers from ~openstack-charmers-next during release HOT 1
- Split charms.txt into charms.txt and release-charms.txt to signal the difference between maintained charms and released charms
- Due to the OpenStack dropping py35 from latest releases, we have to pin the following packages
- `tox -e ...` on charms fails with ResolutionImpossible HOT 7
- Pinning of pip and setuptools on tox 2.5 (bionic) doesn't work HOT 1
- Need to resolve how to do build-lock files (and manage them properly) in a charmcraft world
- Improve the `add-gerrit-remote` script to use parsed project url/name from .gitreview
- Use the charmcraft reactive plugin instead of using overrides (also unlock charmcraft pin at 1.5/stable)
- Use parsed details from .gitreview for check-repo-links script
- Provide example of .config/charmhub_lp_tools/config.yaml
- No support for reactive charms with multiple bases HOT 2
- Populate Charm Store vcs-revisions Field
- No osci.yaml management
- No operator framework (ops) support
- charms.ceph sync tool does not recognize a git branch Edit
- mysql-innodb-cluster uses a resource with a .snap extension -- charm-pusher tool can't handle that at present
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from release-tools.