Giter Club home page Giter Club logo

Comments (3)

ryan-beisner avatar ryan-beisner commented on August 12, 2024

It's not clear to me what this means. Please expand on this issue / feature request. Thank you.

from release-tools.

andrewdmcleod avatar andrewdmcleod commented on August 12, 2024

At the end of the release process there was a requirement to have individuals +1 the PRs (not necessarily approvers) and there was confusion on who was doing it, which they were doing, whether they were duplicating it, etc.

It would make sense to have a simple script into which you input names (emails) which generates PR URLs for those email-users to click on and +1 (while there was not a huge amount of PRs, there may also be more in future). This script could also include an 'expected diff' since on one hand we have already reviewed the changes to get to this point, and the +1 is in essence a tip of the hat, there should be SOME sanity check. This expected diff "example" should be minimal since it is just a branch/release switch/cut.

This could be part of the larger "release" script which was suggested in another issue.

from release-tools.

ryan-beisner avatar ryan-beisner commented on August 12, 2024

Ah ok. So, we discussed whether or not to pursue automatic CR voting on the batch and decided against it. ie. The bot can vote on tests, but should not do code-review voting.

Whether a human is comfortable with scripting an iterative code-review plus-vote is a different debate, and may or may not be desired per-individual.

I don't think we should script it.

from release-tools.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.