Comments (9)
mattcaswell
commented on August 16, 2024
I note that at the moment we have 264 open PRs. Many of those probably come under the classification of "stalled". It wouldn't be helpful to see 200+ emails in my inbox notifying me of those stalled PRs. Could we limit it somehow to those PRs that were recently active, but now don't seem to be?
Having stats would be very useful. For example:
X PRs opened in the last week
X PRs closed in the last week
X open PRs are 1 month old or less
X open PRs are 1-2 months old
X open PRs are 2-4 months old
X open PRs are 4-6 months old
X open PRs are older than 6 months
This sort of thing we could track over time and set some goals around.
from tools.
richsalz
commented on August 16, 2024
I suggest a weekly mail that summarizes things perhaps via a table by PR.
from tools.
paulidale
commented on August 16, 2024
@mattcaswell's suggestion with a list of clickable PRs after the summary (ideally sorted into the same categories).
Weekly is probably about the right frequency. Such reminders need to be sufficiently non-annoying that they get looked at.
from tools.
mspncp
commented on August 16, 2024
sufficiently non-annoying
Interesting formulation.
from tools.
richsalz
commented on August 16, 2024
Post it to openssl-users, not the project or commits. Make it public. You want more metrics, you can do that with a less-public list. Look at "pull panda" for example.
from tools.
t8m
commented on August 16, 2024
It would be also interesting to see for the "stalled" PRs on which side the action is - whether the reporter or the team. We would probably need a new label for that.
from tools.
iamamoose
commented on August 16, 2024
I'm running this daily and tweaking it and it'll eventually get auto emailed out probably weekly. Example from last night ("stalled issues" where "stalled" means no update in 30 days)
all ( 179 issues, median 135 days)
list of prs suppressed
failed CI ( 28 issues, median 136.5 days)
10954 days:41
10828 branch: 1.1.1, branch: master, reviewed:commented days:45
10556 days:94
10465 days:111
10344 branch: master, days:126
10185 days:70
10144 branch: master, reviewed:commented days:83
10124 days:143
10076 branch: master, days:158
9926 days:173
9759 branch: master, reviewed:commented days:117
9603 days:173
9389 branch: master, reviewed:commented days:55
9155 reviewed:commented days:47
8955 branch: 1.1.1, branch: master, reviewed:dismissed days:122
8871 branch: master, reviewed:commented days:138
8687 reviewed:commented days:157
8389 days:362
8283 branch: master, reviewed:commented days:376
7921 reviewed:commented days:366
7918 branch: 1.0.2, branch: 1.1.1, branch: master, reviewed:commented days:92
7914 reviewed:approved days:425
7719 days:459
7380 reviewed:commented days:513
7051 milestone:Assessed, reviewed:commented days:562
6074 milestone:Assessed, reviewed:commented days:605
4992 milestone:Assessed, reviewed:commented days:135
4606 branch: 1.1.1, branch: master, milestone:Assessed, reviewed:commented days:41
cla required ( 25 issues, median 347 days)
list of prs suppressed
all other ( 50 issues, median 273.0 days)
10895 branch: master, reviewed:commented days:45
10884 days:49
10818 days:55
10755 branch: master, reviewed:commented days:60
10570 reviewed:commented days:71
10541 days:86
10338 reviewed:commented days:126
10320 branch: 1.1.1, branch: master, reviewed:commented days:117
10298 days:130
10268 days:132
10037 days:94
9942 days:171
9655 days:104
9554 days:213
9421 branch: 1.1.1, branch: master, reviewed:approved days:68
9223 branch: master, reviewed:commented days:30
9206 days:261
9051 reviewed:commented days:124
8956 days:283
8920 days:160
8908 days:298
8862 days:277
8835 days:317
8743 branch: master, days:328
8668 days:339
8525 days:128
8455 days:341
8420 days:342
8333 days:377
8309 branch: master, reviewed:commented days:263
8200 reviewed:commented days:125
7943 reviewed:approved days:438
7733 reviewed:commented days:459
7718 days:459
7688 days:463
7615 days:467
7485 branch: 1.1.1, branch: master, reviewed:commented days:493
7454 reviewed:commented days:418
7450 branch: 1.1.1, branch: master, reviewed:commented days:491
7274 reviewed:approved days:269
7225 reviewed:commented days:534
6725 milestone:Assessed, reviewed:approved days:277
6518 milestone:Assessed, reviewed:approved days:628
6516 branch: 1.1.1, branch: master, milestone:Assessed, days:628
6448 milestone:Assessed, days:135
6219 milestone:Assessed, reviewed:approved days:666
5860 branch: 1.1.1, branch: master, milestone:Assessed, reviewed:commented days:199
5427 branch: master, milestone:Assessed, reviewed:commented days:428
4487 milestone:Assessed, days:605
4486 milestone:Assessed, days:605
waiting for reporter ( 16 issues, median 225.5 days)
10787 branch: master, reviewed:changes_requested days:59
10724 reviewed:changes_requested days:53
10590 reviewed:changes_requested days:62
9956 reviewed:changes_requested days:170
9575 reviewed:changes_requested days:209
9461 reviewed:changes_requested days:222
9427 reviewed:changes_requested days:229
9243 reviewed:changes_requested days:231
9240 reviewed:changes_requested days:256
8992 reviewed:changes_requested days:173
8962 reviewed:changes_requested days:292
8730 reviewed:changes_requested days:270
8674 reviewed:changes_requested days:325
7961 reviewed:changes_requested days:427
7432 reviewed:changes_requested days:506
2986 milestone:Assessed, reviewed:changes_requested days:135
deferred after 1.1.1 ( 52 issues, median 135.0 days)
list of prs suppressed
waiting for review ( 3 issues, median 41 days)
10489 approval: review pending, branch: master, reviewed:approved days:41
10301 approval: review pending, branch: 1.1.1, branch: master, reviewed:approved days:30
8916 approval: review pending, branch: 1.1.1, branch: master, reviewed:approved days:102
waiting for OMC ( 2 issues, median 369.5 days)
10195 branch: master, hold: need omc decision, reviewed:commented days:119
5909 hold: need omc decision, milestone:Assessed, reviewed:changes_requested days:620
waiting for OTC ( 3 issues, median 32 days)
9537 approval: otc review pending, reviewed:commented days:32
8706 approval: otc review pending, branch: master, reviewed:approved days:135
8300 approval: otc review pending, branch: 1.1.1, branch: master, hold: need otc decision, reviewed:approved days:31
from tools.
levitte
commented on August 16, 2024
Has this been resolved in a satisfactory manner?
from tools.
nhorman
commented on August 16, 2024
given there was no response to @levitte comment 2 years ago, i'm assuming this is complete. Marking as inactive to be closed in the near future. Please comment if there is more to do here
from tools.
Related Issues (20)
- Lost (read) access to upstream tools repository HOT 5
- addrev needs adjusting for release commits HOT 3
- addrev shouldn't require two reviewers for the web or tools repos HOT 9
- addrev --release requires too many reviewers HOT 1
- > Dappskick`
- addrev script can't locate OpenSSL/Query/REST.pm HOT 11
- Commits pushed by `pick_to_branch` tend to get lost HOT 8
- Announcement text for premium releases needs to be changed
- `addrev` fails with `Server error: Can't verify SSL peers without knowing which Certificate Authorities to trust` HOT 6
- The digest files of release tarballs contain extra space before the hash
- Default for the stage release script should not be the current user HOT 2
- The release staging script auto-uploads to the server even for releases that it shouldn't
- The staging script does not always issue the correct "push" instructions
- The staging script uses the wrong email announcement template for 1.1.1
- Email announcements user is unclear/wrong
- (submitted to wrong place) HOT 1
- Do CLA trivial label magic HOT 2
- Man pages for master on the website are incomplete HOT 3
- Move last run-checker jobs to GitHub Actions HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tools.