Giter Club home page Giter Club logo

Comments (7)

ravitri avatar ravitri commented on June 20, 2024 1

@damemi , @ingvagabund - In addition to the upgrades, the other scenarios I can think of which could possibly disrupt existing core workloads is node/machine replacements/addition/removal. For now, the worker and infra nodes are supported as part of this but in future will be extended to control plane too (subject to change). Another scenario can be a MachineConfig change to cause rolling reboot of nodes in the respective MachineConfigPool (triggered change which is not an upgrade).

Considering above scenarios as well, I think we might need to stretch openshift* namespace inclusion criteria further. WDYT?

from cluster-kube-descheduler-operator.

ingvagabund avatar ingvagabund commented on June 20, 2024

We might also introduce a new profile which will do this right before/after the upgrade if this is the only use case. Make it part of the upgrade itself (pre/post-upgrade steps).

from cluster-kube-descheduler-operator.

wking avatar wking commented on June 20, 2024

Descheduler is very polite by using the eviction API. We have efforts like openshift/origin#26160 underway to improve our PDB coverage. If folks using the eviction API can cause excessive disruption in the OpenShift core, that sounds like it's really a missing/miscongured PDB situation to me. I expect we have some bugs like that today. Hopefully openshift/origin#26160 turns them up, and we get them fixed. Once we get them fixed, can we pivot to having the descheduler cover the kube-system and openshift-* namespaces by default? Because "don't ask about evicting us, we don't handle that well" doesn't seem like a good long-term plan.

from cluster-kube-descheduler-operator.

openshift-bot avatar openshift-bot commented on June 20, 2024

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

from cluster-kube-descheduler-operator.

openshift-bot avatar openshift-bot commented on June 20, 2024

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

from cluster-kube-descheduler-operator.

openshift-bot avatar openshift-bot commented on June 20, 2024

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

from cluster-kube-descheduler-operator.

openshift-ci avatar openshift-ci commented on June 20, 2024

@openshift-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

from cluster-kube-descheduler-operator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.