Comments (1)
The code to delete the Machine was added in #51, so we will have to think carefully about how the use case addressed by that (which doesn't appear to be well documented) will still be addressed.
In the case where we're forcing the MachineSet to use all of the available Host inventory, going to the Failed phase should work fine: if a Host is deleted then the MachineSet will be scaled down and it is the unhealthy Machine that will be removed.
In the case where we're using the cluster autoscaler, things should work themselves out.
In the case where a MachineHealthCheck is operating, any Failed machines will be deleted (once the PR above is merged).
Only in the case where:
- There is excess Host inventory
- No autoscaling is enabled
- No MachineHealthCheck is enabled
would there be a change in behaviour. (Currently a new Machine would be created automatically, using one of the spare Hosts; if we don't delete the existing Machine then it will continue to exist in a Failed state until somebody deletes it manually, and no replacement would be created unless somebody manually deletes it or scales up the MachineSet. This would be consistent with how it works on other machine api providers.)
from cluster-api-provider-baremetal.
Related Issues (20)
- No indication that a Machine can't acquire a Host
- Machine->Host mapping is not necessarily unique over time HOT 2
- BareMetalHost doesn't reconcile when a Machine config is specified with the BMH as the providerID HOT 5
- Future Release Branches Frozen For Merging | branch:release-4.1 branch:release-4.0
- Future Release Branches Frozen For Merging | branch:release-4.16 branch:release-4.17
- Future Release Branches Frozen For Merging | branch:release-4.1 branch:release-4.0
- Future Release Branches Frozen For Merging | branch:release-4.1 branch:release-4.0
- Future Release Branches Frozen For Merging | branch:release-4.1 branch:release-4.0
- Future Release Branches Frozen For Merging | branch:release-4.1 branch:release-4.0
- Future Release Branches Frozen For Merging | branch:release-4.10 branch:release-4.9 HOT 4
- Mismatched dependencies for CAPB and openshift/cluster-api HOT 4
- Document downstream delete annotation HOT 4
- make manifests returns "Error: no kustomization.yaml file under /tmp/kustomize-490795293/config"
- "make test" fails on older version of kustomize
- Deleting a Host doesn't immediately affect Machine HOT 9
- change vendored cluster-api to machine-api-operator
- Metrics port change to support updated MAO metrics integration
- Add liveness/readiness probes
- ignore externally provisioned hosts when fulfilling a machine
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cluster-api-provider-baremetal.